[PATCH v2] app/testpmd: enable cli for programmable action

[Stephen Hemminger]

On Thu,  5 Oct 2023 07:42:38 -0400
Qi Zhang <qi.z.zhang at intel.com> wrote:

> +	char name[ACTION_PROG_NAME_SIZE_MAX];
> +	struct rte_flow_action_prog_argument args[ACTION_PROG_ARG_NUM_MAX];
> +	char arg_names[ACTION_PROG_ARG_NUM_MAX][ACTION_PROG_NAME_SIZE_MAX];
> +	uint8_t value[ACTION_PROG_ARG_NUM_MAX][ACTION_PROG_ARG_VALUE_SIZE_MAX];
> +};
> +

IMHO if you have this many array elements the data structure makes more sense as.

	struct flow_arg {
		char name[ACTION_PROG_NAME_SIZE_MAX];
		struct {
			struct rte_flow_prog_argument prog;
			char names[ACTION_PROG_NAME_SIZE_MAX];
			uint8_t value[ACTION_PROG_ARG_VALUE_SIZE_MAX];
		} args[ACTION_PROG_ARG_NUM_MAX];
	};

Or better yet get rid of PROG_ARG_NUM_MAX and use a flex array.
Somebody will want more than 8 args.