[PATCH v4 28/28] port: make API's stable

Dumitrescu, Cristian cristian.dumitrescu at intel.com
Fri Oct 20 12:11:40 CEST 2023



> -----Original Message-----
> From: Stephen Hemminger <stephen at networkplumber.org>
> Sent: Thursday, October 19, 2023 8:10 PM
> To: dev at dpdk.org
> Cc: Stephen Hemminger <stephen at networkplumber.org>; Dumitrescu,
> Cristian <cristian.dumitrescu at intel.com>
> Subject: [PATCH v4 28/28] port: make API's stable
> 
> Follow the guidelines already in deprecation.rst and
> make the API's stable, even though they are marked as deprecated.
> 
> Note: this library never properly marked its experimental API's.
> The API's were in the EXPERIMENTAL section but the macro
> __rte_experimental was missing.
> 
> Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
> ---
>  doc/guides/rel_notes/deprecation.rst |   4 -
>  lib/pipeline/rte_port_in_action.h    |   8 --
>  lib/pipeline/rte_swx_ctl.h           |  57 -----------
>  lib/pipeline/rte_swx_pipeline.h      |  29 ------
>  lib/pipeline/rte_table_action.h      |  16 ---
>  lib/pipeline/version.map             | 140 ++++++++++++---------------
>  lib/port/version.map                 |  24 ++---
>  7 files changed, 69 insertions(+), 209 deletions(-)
> 

NAK.

As the deprecation notice states, the old API is planned for removal:
https://git.dpdk.org/dpdk/tree/doc/guides/rel_notes/deprecation.rst#n135

As discussed before, it is bad practice to mark as stable API that is planned for removal.


More information about the dev mailing list