[PATCH 04/24] net/axgbe: check mdio for non-zero ports and CL45 PHYs

[Ferruh Yigit]

On 4/12/2024 1:52 PM, Venkat Kumar Ande wrote:
> The XGBE hardware has support for performing MDIO operations using an
> MDIO command request. The driver mistakenly uses the mdio port address
> as the MDIO command request device address instead of the MDIO command
> request port address. Additionally, the driver does not properly check
> for and create a clause 45 MDIO command.
> 
> Check the supplied MDIO register to determine if the request is a clause
> 45 operation (MII_ADDR_C45). For a clause 45 operation, extract device
> address and register number from the supplied MDIO register and use them
> to set the MDIO command request device address and register number fields.
> For a clause 22 operation, the MDIO request device address is set to zero
> and the MDIO command request register number is set to the supplied MDIO
> register. In either case, the supplied MDIO port address is used as the
> MDIO command request port address.
> 
> Signed-off-by: Venkat Kumar Ande <VenkatKumar.Ande at amd.com>
>

Hi Venkat,

I can see this commit fixes the mdio command, and commit log clearly
explains what was wrong and what is fixed.

But it is not possible to get what was the impact and what is fixed from
user perspective.
Like when MDIO command request was formed badly, what was wrong for
user, was driver completely not usable or setting some link config was
broken, or something else etc...

Same is valid for a few more commits in this set, can you please
describe the user impact in the commit log? This also helps users to
understand the priority of the issue/fix.

Thanks,
ferruh