[PATCH v6 00/23] stop and remove RTE_MARKER typedefs
Tyler Retzlaff
roretzla at linux.microsoft.com
Tue Feb 27 06:41:16 CET 2024
RTE_MARKER typedefs are a GCC extension unsupported by MSVC. This series
stops referencing and removes the markers.
This series, does the following.
* RTE_MARKER{,816,32,64} fields are removed from all structures.
* Moves duplicated assertions referencing marker fields to
rte_mbuf_core.h and updates them to be based on static_assert
using non marker field names.
* Updates prefetch inline functions to calculate the address to
prefetch for cachline0 and cacheline1 without the markers.
* Introduces 2 new inline functions for accessing rearm_data
and rx_descriptor_fields1 descriptor to decouple from use
of the marker field names so that they can be removed.
* Updates driver access to use new inline descriptors.
v6:
* remove all rte marker fields and note their removal in release
notes.
* move duplicated assertions to global scope with struct rte_mbuf.
* calculate cacheline{0,1} addresses without using struct rte_mbuf
fields.
* added comments into struct rte_mbuf field directing readers to
use inline accessors for rearm_data and rx_descriptor_fields1
descriptors.
* added checkpatches check to block new additions using RTE_MARKER
typedefs.
* switch to using alignas to align cacheline1 in modified structs.
* removed __rte_marker macro as it was not desired and is now not
needed.
v5:
* update existing cacheline{0, 1} inline functions to access actual
mbuf fields.
* introduce new inline functions for accessing rearm_data and
rx_descriptor_fields1 descriptors.
* adapt drivers to use new inline functions.
prior versions not relevant due to re-work of entire series.
Tyler Retzlaff (23):
mbuf: add accessors for rearm and Rx descriptor fields
mbuf: consolidate driver asserts for mbuf struct
common/idpf: use mbuf descriptor accessors
net/bnxt: use mbuf descriptor accessors
net/cnxk: use mbuf descriptor accessors
net/enic: use mbuf descriptor accessors
net/fm10k: use mbuf descriptor accessors
net/hns3: use mbuf descriptor accessors
net/i40e: use mbuf descriptor accessors
net/iavf: use mbuf descriptor accessors
net/ice: use mbuf descriptor accessors
net/ionic: use mbuf descriptor accessors
net/ixgbe: use mbuf descriptor accessors
net/mlx5: use mbuf descriptor accessors
net/octeon_ep: use mbuf descriptor accessors
net/sfc: use mbuf descriptor accessors
net/thunderx: use mbuf descriptor accessors
net/virtio: use mbuf descriptor accessors
examples/dma: use mbuf descriptor accessor
mbuf: remove and stop using rte marker fields
security: remove rte marker fields
cryptodev: remove rte marker fields
devtools: forbid new use of rte marker typedefs
devtools/checkpatches.sh | 8 +++
doc/guides/rel_notes/release_24_03.rst | 15 +++++
drivers/common/idpf/idpf_common_rxtx.c | 4 +-
drivers/common/idpf/idpf_common_rxtx_avx512.c | 73 +++++----------------
drivers/net/bnxt/bnxt_rxtx_vec_avx2.c | 32 +++++-----
drivers/net/bnxt/bnxt_rxtx_vec_common.h | 4 +-
drivers/net/bnxt/bnxt_rxtx_vec_neon.c | 16 ++---
drivers/net/bnxt/bnxt_rxtx_vec_sse.c | 16 ++---
drivers/net/cnxk/cn10k_rx.h | 36 +++++------
drivers/net/cnxk/cn9k_rx.h | 20 +++---
drivers/net/cnxk/cnxk_ethdev.c | 2 +-
drivers/net/enic/enic_main.c | 4 +-
drivers/net/enic/enic_rxtx_vec_avx2.c | 18 +++---
drivers/net/fm10k/fm10k_rxtx_vec.c | 32 ++--------
drivers/net/hns3/hns3_rxtx_vec.c | 22 +------
drivers/net/hns3/hns3_rxtx_vec_neon.h | 24 +++----
drivers/net/hns3/hns3_rxtx_vec_sve.c | 4 +-
drivers/net/i40e/i40e_rxtx_vec_altivec.c | 18 ++----
drivers/net/i40e/i40e_rxtx_vec_avx2.c | 34 +++-------
drivers/net/i40e/i40e_rxtx_vec_avx512.c | 35 +++-------
drivers/net/i40e/i40e_rxtx_vec_common.h | 4 +-
drivers/net/i40e/i40e_rxtx_vec_neon.c | 16 ++---
drivers/net/i40e/i40e_rxtx_vec_sse.c | 43 +++----------
drivers/net/iavf/iavf_rxtx_vec_avx2.c | 72 +++++----------------
drivers/net/iavf/iavf_rxtx_vec_avx512.c | 72 +++++----------------
drivers/net/iavf/iavf_rxtx_vec_common.h | 4 +-
drivers/net/iavf/iavf_rxtx_vec_neon.c | 16 ++---
drivers/net/iavf/iavf_rxtx_vec_sse.c | 85 +++++--------------------
drivers/net/ice/ice_rxtx_vec_avx2.c | 36 +++--------
drivers/net/ice/ice_rxtx_vec_avx512.c | 37 +++--------
drivers/net/ice/ice_rxtx_vec_common.h | 4 +-
drivers/net/ice/ice_rxtx_vec_sse.c | 44 +++----------
drivers/net/ionic/ionic_lif.c | 6 +-
drivers/net/ionic/ionic_rxtx_sg.c | 4 +-
drivers/net/ionic/ionic_rxtx_simple.c | 2 +-
drivers/net/ixgbe/ixgbe_rxtx_vec_common.h | 4 +-
drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c | 12 ++--
drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c | 51 ++++-----------
drivers/net/mlx5/mlx5_rxq.c | 2 +-
drivers/net/mlx5/mlx5_rxtx_vec.h | 19 ------
drivers/net/mlx5/mlx5_rxtx_vec_altivec.h | 28 ++++----
drivers/net/mlx5/mlx5_rxtx_vec_neon.h | 20 +++---
drivers/net/mlx5/mlx5_rxtx_vec_sse.h | 28 ++++----
drivers/net/octeon_ep/cnxk_ep_rx.h | 2 +-
drivers/net/octeon_ep/cnxk_ep_rx_avx.c | 2 +-
drivers/net/octeon_ep/cnxk_ep_rx_neon.c | 8 +--
drivers/net/octeon_ep/cnxk_ep_rx_sse.c | 8 +--
drivers/net/octeon_ep/otx_ep_rxtx.c | 5 +-
drivers/net/sfc/sfc_ef100_rx.c | 7 +-
drivers/net/sfc/sfc_ef10_rx.c | 10 +--
drivers/net/thunderx/nicvf_ethdev.c | 4 +-
drivers/net/thunderx/nicvf_rxtx.h | 4 +-
drivers/net/virtio/virtio_rxtx_packed.h | 4 +-
drivers/net/virtio/virtio_rxtx_packed_avx.h | 16 ++---
drivers/net/virtio/virtio_rxtx_packed_neon.h | 18 +++---
drivers/net/virtio/virtio_rxtx_simple.c | 4 +-
drivers/net/virtio/virtio_rxtx_simple.h | 5 +-
drivers/net/virtio/virtio_rxtx_simple_altivec.c | 16 ++---
drivers/net/virtio/virtio_rxtx_simple_neon.c | 24 +++----
drivers/net/virtio/virtio_rxtx_simple_sse.c | 16 ++---
examples/dma/dmafwd.c | 5 +-
lib/cryptodev/cryptodev_pmd.h | 5 +-
lib/mbuf/rte_mbuf.h | 17 ++++-
lib/mbuf/rte_mbuf_core.h | 50 ++++++++++++---
lib/security/rte_security_driver.h | 5 +-
65 files changed, 445 insertions(+), 816 deletions(-)
--
1.8.3.1
More information about the dev
mailing list