[PATCH v2] app/test-crypto-perf: fix invalid mbuf next operation
Suanming Mou
suanmingm at nvidia.com
Thu Jan 4 03:24:05 CET 2024
In fill_multi_seg_mbuf(), when remaining_segments is 0,
rte_mbuf m's next should pointer to NULL instead of a
new rte_mbuf, that causes setting m->next as NULL out
of the while loop to the invalid mbuf.
This commit fixes the invalid mbuf next operation.
Fixes: bf9d6702eca9 ("app/crypto-perf: use single mempool")
Signed-off-by: Suanming Mou <suanmingm at nvidia.com>
---
v2: move next_mbuf inside remaining_segments check.
---
app/test-crypto-perf/cperf_test_common.c | 15 +++++++--------
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/app/test-crypto-perf/cperf_test_common.c b/app/test-crypto-perf/cperf_test_common.c
index 932aab16df..b3bf9f67e8 100644
--- a/app/test-crypto-perf/cperf_test_common.c
+++ b/app/test-crypto-perf/cperf_test_common.c
@@ -49,7 +49,6 @@ fill_multi_seg_mbuf(struct rte_mbuf *m, struct rte_mempool *mp,
{
uint16_t mbuf_hdr_size = sizeof(struct rte_mbuf);
uint16_t remaining_segments = segments_nb;
- struct rte_mbuf *next_mbuf;
rte_iova_t next_seg_phys_addr = rte_mempool_virt2iova(obj) +
mbuf_offset + mbuf_hdr_size;
@@ -70,15 +69,15 @@ fill_multi_seg_mbuf(struct rte_mbuf *m, struct rte_mempool *mp,
m->nb_segs = segments_nb;
m->port = 0xff;
rte_mbuf_refcnt_set(m, 1);
- next_mbuf = (struct rte_mbuf *) ((uint8_t *) m +
- mbuf_hdr_size + segment_sz);
- m->next = next_mbuf;
- m = next_mbuf;
- remaining_segments--;
+ remaining_segments--;
+ if (remaining_segments > 0) {
+ m->next = (struct rte_mbuf *)((uint8_t *) m + mbuf_hdr_size + segment_sz);
+ m = m->next;
+ } else {
+ m->next = NULL;
+ }
} while (remaining_segments > 0);
-
- m->next = NULL;
}
static void
--
2.34.1
More information about the dev
mailing list