[PATCH v4 1/4] baseband/fpga_5gnr_fec: renaming for consistency
Chautru, Nicolas
nicolas.chautru at intel.com
Wed Jan 10 18:19:44 CET 2024
Thanks Stephen.
Noted, I believe this is okay for that very case, but I agree there is good balance between being explicit and being readable.
Thanks
Nic
> -----Original Message-----
> From: Stephen Hemminger <stephen at networkplumber.org>
> Sent: Friday, January 5, 2024 2:00 PM
> To: Vargas, Hernan <hernan.vargas at intel.com>
> Cc: dev at dpdk.org; gakhil at marvell.com; Rix, Tom <trix at redhat.com>;
> maxime.coquelin at redhat.com; Chautru, Nicolas <nicolas.chautru at intel.com>;
> Zhang, Qi Z <qi.z.zhang at intel.com>
> Subject: Re: [PATCH v4 1/4] baseband/fpga_5gnr_fec: renaming for
> consistency
>
> On Fri, 5 Jan 2024 13:15:16 -0800
> Hernan Vargas <hernan.vargas at intel.com> wrote:
>
> > +#define FPGA_5GNR_QUEUE_FLUSH_TIMEOUT_US (1000)
>
> Just my opinion, no need it doesn't have to change but.
> These variable names are getting quite long which doesn't improve readability.
More information about the dev
mailing list