[EXT] Re: [PATCH 1/2] ethdev: parsing multiple representor devargs string

[Harman Kalra]

Hi David

Thanks for review
Please find responses inline

> -----Original Message-----
> From: David Marchand <david.marchand at redhat.com>
> Sent: Friday, January 12, 2024 6:12 PM
> To: Harman Kalra <hkalra at marvell.com>
> Cc: Ajit Khaparde <ajit.khaparde at broadcom.com>; Somnath Kotur
> <somnath.kotur at broadcom.com>; John Daley <johndale at cisco.com>;
> Hyong Youb Kim <hyonkim at cisco.com>; Yuying Zhang
> <Yuying.Zhang at intel.com>; Beilei Xing <beilei.xing at intel.com>; Qiming Yang
> <qiming.yang at intel.com>; Qi Zhang <qi.z.zhang at intel.com>; Wenjun Wu
> <wenjun1.wu at intel.com>; Dariusz Sosnowski <dsosnowski at nvidia.com>;
> Viacheslav Ovsiienko <viacheslavo at nvidia.com>; Ori Kam
> <orika at nvidia.com>; Suanming Mou <suanmingm at nvidia.com>; Matan
> Azrad <matan at nvidia.com>; Chaoyong He <chaoyong.he at corigine.com>;
> Andrew Rybchenko <andrew.rybchenko at oktetlabs.ru>; Thomas Monjalon
> <thomas at monjalon.net>; Ferruh Yigit <ferruh.yigit at amd.com>;
> dev at dpdk.org
> Subject: [EXT] Re: [PATCH 1/2] ethdev: parsing multiple representor devargs
> string
> 
> External Email
> 
> ----------------------------------------------------------------------
> On Thu, Jan 11, 2024 at 7:45 AM Harman Kalra <hkalra at marvell.com>
> wrote:
> >
> > Adding support for parsing multiple representor devargs strings passed
> > to a PCI BDF. There may be scenario where port representors for
> > various PFs or VFs under PFs are required and all these are
> > representor ports shall be backed by single pci device. In such case
> > port representors can be created using devargs string:
> > <PCI
> > BDF>,representor=pf[0-1],representor=pf2vf[1,2-3],representor=[4-5]
> 
> Is it possible to make the representor devargs value a list?
> Like: <PCI BDF>,representor=[pf[0-1],pf2vf[1,2-3],[4-5]]

Thanks for suggestion, even I was not so happy with repeated representor keywork.
Please review the changes:
https://patches.dpdk.org/project/dpdk/patch/20240115155715.111154-2-hkalra@marvell.com/

Thanks
Harman


> 
> 
> --
> David Marchand