[PATCH v4 4/4] baseband/fpga_5gnr_fec: cosmetic comment changes

Maxime Coquelin maxime.coquelin at redhat.com
Tue Jan 16 14:12:48 CET 2024



On 1/5/24 22:15, Hernan Vargas wrote:
> Cosmetic changes for comments.
> No functional impact.
> 
> Signed-off-by: Hernan Vargas <hernan.vargas at intel.com>
> ---
>   drivers/baseband/fpga_5gnr_fec/agx100_pmd.h   |   4 +-
>   .../baseband/fpga_5gnr_fec/fpga_5gnr_fec.h    |  49 ++--
>   .../fpga_5gnr_fec/rte_fpga_5gnr_fec.c         | 248 +++++++++---------
>   .../fpga_5gnr_fec/rte_pmd_fpga_5gnr_fec.h     |  16 +-
>   4 files changed, 157 insertions(+), 160 deletions(-)
> 

...

>   
> @@ -2714,14 +2714,14 @@ vc_5gnr_dequeue_ldpc_dec_one_op_cb(struct fpga_5gnr_queue *q, struct rte_bbdev_d
>   	union vc_5gnr_dma_desc *desc;
>   	int desc_error;
>   
> -	/* Set descriptor */
> +	/* Set descriptor. */
>   	desc = vc_5gnr_get_desc(q, desc_offset);
>   
> -	/* Verify done bit is set */
> +	/* Verify done bit is set. */
>   	if (desc->dec_req.done == 0)
>   		return -1;
>   
> -	/* make sure the response is read atomically */
> +	/* make sure the response is read atomically. */

While at it, you could make all comments starting with upper case for
consistency, here and elsewhere in the driver.



More information about the dev mailing list