[PATCH] cryptodev: add a simple mapping cache to speed up ops pool create
Andrew Boyer
andrew.boyer at amd.com
Fri Jan 19 17:41:22 CET 2024
Cache the most recent VA -> PA mapping found so that we can skip
most of the system calls. With 4K pages this reduces pool create
time by about 90%.
Signed-off-by: Andrew Boyer <andrew.boyer at amd.com>
---
lib/cryptodev/rte_crypto.h | 5 +++++
lib/cryptodev/rte_cryptodev.c | 23 ++++++++++++++++++++++-
2 files changed, 27 insertions(+), 1 deletion(-)
diff --git a/lib/cryptodev/rte_crypto.h b/lib/cryptodev/rte_crypto.h
index dbc2700da5..ee6aa1e40e 100644
--- a/lib/cryptodev/rte_crypto.h
+++ b/lib/cryptodev/rte_crypto.h
@@ -220,6 +220,11 @@ struct rte_crypto_op_pool_private {
/**< Crypto op pool type operation. */
uint16_t priv_size;
/**< Size of private area in each crypto operation. */
+
+ unsigned long vp_cache;
+ /* Virtual page address of previous op. */
+ rte_iova_t iovp_cache;
+ /* I/O virtual page address of previous op. */
};
diff --git a/lib/cryptodev/rte_cryptodev.c b/lib/cryptodev/rte_cryptodev.c
index b233c0ecd7..d596f85a57 100644
--- a/lib/cryptodev/rte_cryptodev.c
+++ b/lib/cryptodev/rte_cryptodev.c
@@ -10,6 +10,7 @@
#include <errno.h>
#include <stdint.h>
#include <inttypes.h>
+#include <unistd.h>
#include <rte_log.h>
#include <rte_debug.h>
@@ -2568,12 +2569,32 @@ rte_crypto_op_init(struct rte_mempool *mempool,
{
struct rte_crypto_op *op = _op_data;
enum rte_crypto_op_type type = *(enum rte_crypto_op_type *)opaque_arg;
+ struct rte_crypto_op_pool_private *priv;
+ unsigned long virt_addr = (unsigned long)(uintptr_t)_op_data;
+#ifdef RTE_EXEC_ENV_WINDOWS
+ unsigned long page_mask = 4095;
+#else
+ unsigned long page_mask = sysconf(_SC_PAGESIZE) - 1;
+#endif
+ unsigned long virt_page = virt_addr & ~page_mask;
memset(_op_data, 0, mempool->elt_size);
__rte_crypto_op_reset(op, type);
- op->phys_addr = rte_mem_virt2iova(_op_data);
+ priv = (struct rte_crypto_op_pool_private *)
+ rte_mempool_get_priv(mempool);
+
+ if (virt_page == priv->vp_cache) {
+ op->phys_addr = priv->iovp_cache + (virt_addr & page_mask);
+ } else {
+ op->phys_addr = rte_mem_virt2iova(_op_data);
+
+ /* Update cached values */
+ priv->vp_cache = virt_page;
+ priv->iovp_cache = op->phys_addr & ~page_mask;
+ }
+
op->mempool = mempool;
}
--
2.17.1
More information about the dev
mailing list