[PATCH v6 00/20] Remove uses of PMD logtype

Stephen Hemminger stephen at networkplumber.org
Fri Jan 19 17:58:30 CET 2024


On Fri, 19 Jan 2024 14:59:58 +0100
David Marchand <david.marchand at redhat.com> wrote:

> This series mixes unrelated changes, like adding missing \n or
> removing some of them.
> I identified a couple of places where it introduces issues by doing so.
> 
> Please focus on changing the logtype / log macros and not silently
> "fix" other log issues.
> We can fix the latter, later.
> 
> 
> Details of what I spotted:
> 
> - there is the "funny" case of event/dlb2 where the DLB2_LOG_DBG macro
> does not add a \n, while _INFO and _ERR do,
> 
> - there is also the case of some _DP log macros in some drivers.
> For the drivers below, the _DP macro won't add a \n, while their non
> _DP macro equivalent do add one...

I wonder should _DP macros behave same as non _DP versions around newline.
It makes sense to me that it should always be the same.
If so, let me split that as step 1 in these cases.


More information about the dev mailing list