[PATCH v5 1/2] drivers/net: fix buffer overflow for ptypes list

[Power, Ciara]

Hi Ferruh,

> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit at amd.com>
> Sent: Friday, January 19, 2024 2:59 PM
> To: Sivaramakrishnan, VenkatX <venkatx.sivaramakrishnan at intel.com>;
> Hemant Agrawal <hemant.agrawal at nxp.com>; Sachin Saxena
> <sachin.saxena at nxp.com>; Zyta Szpak <zr at semihalf.com>; Liron Himi
> <lironh at marvell.com>; Chaoyong He <chaoyong.he at corigine.com>;
> Gagandeep Singh <g.singh at nxp.com>; Jerin Jacob <jerinj at marvell.com>;
> Maciej Czekaj <mczekaj at marvell.com>
> Cc: dev at dpdk.org; Power, Ciara <ciara.power at intel.com>;
> pascal.mazon at 6wind.com; shreyansh.jain at nxp.com; tdu at semihalf.com;
> qin.ke at corigine.com; jerin.jacob at caviumnetworks.com; stable at dpdk.org
> Subject: Re: [PATCH v5 1/2] drivers/net: fix buffer overflow for ptypes list
> 
> On 1/18/2024 12:07 PM, Sivaramakrishnan Venkat wrote:
> > Address Sanitizer detects a buffer overflow caused by an incorrect
> > ptypes list. Missing "RTE_PTYPE_UNKNOWN" ptype causes buffer overflow.
> > Fix the ptypes list for drivers.
> >
> > Fixes: 0849ac3b6122 ("net/tap: add packet type management")
> > Fixes: a7bdc3bd4244 ("net/dpaa: support packet type parsing")
> > Fixes: 4ccc8d770d3b ("net/mvneta: add PMD skeleton")
> > Fixes: f3f0d77db6b0 ("net/mrvl: support packet type parsing")
> > Fixes: 71e8bb65046e ("net/nfp: update supported list of packet types")
> > Fixes: 659b494d3d88 ("net/pfe: add packet types and basic statistics")
> > Fixes: 398a1be14168 ("net/thunderx: remove generic passX references")
> > Cc: pascal.mazon at 6wind.com
> > Cc: shreyansh.jain at nxp.com
> > Cc: zr at semihalf.com
> > Cc: tdu at semihalf.com
> > Cc: qin.ke at corigine.com
> > Cc: g.singh at nxp.com
> > Cc: jerin.jacob at caviumnetworks.com
> > Cc: stable at dpdk.org
> >
> > Signed-off-by: Sivaramakrishnan Venkat
> > <venkatx.sivaramakrishnan at intel.com>
> >
> 
> Reviewed-by: Ferruh Yigit <ferruh.yigit at amd.com>
> 
> 
> ("Cc: <email>" shouldn't be in the commit message, but not big deal I can
> remove them while merging.
> If you want to help, in next version please put them after '---', as you are
> already doing with changelog)

Thanks for the review on this one.

The DPDK docs suggest adding the Fixes line + CC in the commit message body - has the guidelines changed for this?
We can update in the next version if that is preferred here though, no problem.

Thanks,
Ciara