回复: [PATCH] lib/telemetry:fix telemetry conns leak in case of socket write fail

1819846787 1819846787 at qq.com
Sat Jan 20 05:18:38 CET 2024


I have modified my  commitlog and resubmitted the patch, but I seem to have forgotten to add a [v2] flag to the patch. Do I need to resubmit the patch again?




------------------ 原始邮件 ------------------
发件人: "David Marchand"<david.marchand at redhat.com>; 
发送时间: 2024年1月19日(星期五) 晚上11:54
收件人: " "<1819846787 at qq.com>; 
抄送: "dev"<dev at dpdk.org>; "ciara.power"<ciara.power at intel.com>; "Bruce Richardson"<bruce.richardson at intel.com>; 
主题: Re: [PATCH] lib/telemetry:fix telemetry conns leak in case of socket write fail





On Fri, Jan 19, 2024 at 12:40 PM sunshaowei01 <1819846787 at qq.com> wrote:
>
> Telemetry can only create 10 conns by default, each of which is processed
> by a thread.
>
> When a thread fails to write using socket, the thread will end directly
> without reducing the total number of conns.
>
> This will result in the machine running for a long time, and if there are
> 10 failures, the telemetry will be unavailable
>

Thanks for the patch, do you know which commit first triggered the issue?
This is needed so we add a Fixes: tag in the commitlog for backporting
the fix in stable releases.
See https://doc.dpdk.org/guides/contributing/patches.html#patch-fix-related-issues

> Signed-off-by: sunshaowei01 <1819846787 at qq.com>

We need your full name in the SoB tag.
Like, for example in my case, it would be David Marchand
<david.marchand at redhat.com>.


-- 
David Marchand
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mails.dpdk.org/archives/dev/attachments/20240120/dacfd293/attachment.htm>


More information about the dev mailing list