[PATCH] net/mana: use rte_pktmbuf_alloc_bulk for allocating RX WQEs

Long Li longli at microsoft.com
Fri Jan 26 02:13:46 CET 2024


> Subject: Re: [PATCH] net/mana: use rte_pktmbuf_alloc_bulk for allocating RX
> WQEs
> 
> On Wed, 24 Jan 2024 18:42:42 -0800
> longli at linuxonhyperv.com wrote:
> 
> > +	struct rte_mbuf **mbufs;
> > +
> > +	mbufs = rte_calloc("mana_rx_mbufs", count, sizeof(struct rte_mbuf *), 0);
> > +	if (!mbufs)
> > +		return -ENOMEM;
> 
> Looks good, you might want to make this numa aware in some future version.
> 
> Reviewed-by: Stephen Hemminger <stephen at networkplumber.org>

Thank you!

I'm sending v2 to fix this.

There are a couple of other places in MANA doing memory allocation that should be NUMA aware. I will send another patch to make them NUMA aware.

Long


More information about the dev mailing list