[EXT] Re: [PATCH] app/testpmd: add command to get Tx queue used count

[Ferruh Yigit]

On 1/29/2024 6:37 AM, Satha Koteswara Rao Kottidi wrote:
>> 
>> ----------------------------------------------------------------------
>> Please doc this command in doc/guides/testpmd_app_ug/testpmd_funcs.rst
>> 
>
> Thanks, will update in next version
>
>> 
>> Also why not extend "show port rxq xxx" command to support txq ?
> 
> txq and rxq are different directions, so  extended "show port " command to support txq similar to rxq command. Could you please give more details if I missed something here.
> 

There is an existing "show port <port_id> rxq <queue_id> desc used
count" command, which is for Rx.

As you are adding support for Tx, instead of adding it as a new command,
existing 'cmd_show_rx_queue_desc_used_count_parsed()' can be extended to
support both Rx and Tx.
You can check 'cmd_show_rx_tx_desc_status_parsed()' as sample.

This also helps to have a unified syntax for Rx and Tx, as your version
is slightly diverging from the Rx one.


And please update 'cmd_help_long_parsed()' help string with relevant change.