[PATCH] net/ice: fix null pointer dereferences
Wenwu Ma
wenwux.ma at intel.com
Fri Mar 1 06:20:29 CET 2024
This patch fixes two null pointer dereferences detected by
coverity scan.
Coverity issue: 414096
Fixes: 6ccef90ff5d3 ("net/ice: support VSI level bandwidth config")
Signed-off-by: Wenwu Ma <wenwux.ma at intel.com>
---
drivers/net/ice/ice_tm.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ice/ice_tm.c b/drivers/net/ice/ice_tm.c
index fbab0b8808..e10ac855f9 100644
--- a/drivers/net/ice/ice_tm.c
+++ b/drivers/net/ice/ice_tm.c
@@ -616,7 +616,10 @@ static int ice_set_node_rate(struct ice_hw *hw,
ICE_MAX_BW,
rate);
if (status) {
- PMD_DRV_LOG(ERR, "Failed to set max bandwidth for node %u", tm_node->id);
+ if (tm_node != NULL)
+ PMD_DRV_LOG(ERR, "Failed to set max bandwidth for node %u", tm_node->id);
+ else
+ PMD_DRV_LOG(ERR, "Failed to set max bandwidth");
return -EINVAL;
}
@@ -630,7 +633,10 @@ static int ice_set_node_rate(struct ice_hw *hw,
ICE_MIN_BW,
rate);
if (status) {
- PMD_DRV_LOG(ERR, "Failed to set min bandwidth for node %u", tm_node->id);
+ if (tm_node != NULL)
+ PMD_DRV_LOG(ERR, "Failed to set min bandwidth for node %u", tm_node->id);
+ else
+ PMD_DRV_LOG(ERR, "Failed to set min bandwidth");
return -EINVAL;
}
--
2.25.1
More information about the dev
mailing list