[PATCH v2] hash: make GFNI stubs inline (again)

Tyler Retzlaff roretzla at linux.microsoft.com
Tue Mar 5 04:58:43 CET 2024


On Mon, Mar 04, 2024 at 07:07:24PM -0800, Stephen Hemminger wrote:
> Tyler found build issues with MSVC and the thash gfni stubs.
> The problem would be link errors from missing symbols.
> 
> This version puts back the rte_thash_gfni function stubs as
> inlines, but instead of logging a message, they panic.
> This is intentional because any application should be checking
> with function rte_thash_gfni_supported() before calling the
> hashing functions here. Better to panic then return zero
> and put out log message which will be ignored...
> 
> Fixes: 07d836e5929d ("hash: uninline GFNI stubs")
> Reported-by: Tyler Retzlaff <roretzla at linux.microsoft.com>
> Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
> ---

Acked-by: Tyler Retzlaff <roretzla at linux.microsoft.com>



More information about the dev mailing list