[PATCH] app/test: don't count skipped tests as executed
Tyler Retzlaff
roretzla at linux.microsoft.com
Tue Mar 5 19:08:52 CET 2024
On Mon, Nov 13, 2023 at 03:05:33PM +0000, Bruce Richardson wrote:
> The logic around skipped tests is a little confusing in the unit test
> runner.
> * Any explicitly disabled tests are counted as skipped but not
> executed.
> * Any tests that return TEST_SKIPPED are counted as both skipped and
> executed, using the same statistics counters.
>
> This makes the stats very strange and hard to correlate, since the
> totals don't add up. One would expect that SKIPPED + EXECUTED +
> UNSUPPORTED == TOTAL, and that PASSED + FAILED == EXECUTED.
>
> To achieve this, mark any tests returning TEST_SKIPPED, or ENOTSUP as
> not having executed.
>
> Signed-off-by: Bruce Richardson <bruce.richardson at intel.com>
> ---
Clearly something that was skipped didn't get executed. Solid change.
Acked-by: Tyler Retzlaff <roretzla at linux.microsoft.com>
More information about the dev
mailing list