[V4] ethdev: restore eth_da init at startup of rte_eth_devargs_parse()

Ferruh Yigit ferruh.yigit at amd.com
Mon Mar 11 15:56:40 CET 2024


On 3/11/2024 12:55 PM, Thierry Herbelot wrote:
> Commit 9a9eb104edf6 ("ethdev: parse multiple representor devargs") removes
> the following variable initialization in rte_eth_devargs_parse():
> 
>     memset(eth_da, 0, sizeof(*eth_da));
> 
> Restore the memset, as this causes regression in ixgbe PCI probe.
> 
> As the listed commit introduces a new argument: nb_da, the memset
> takes it into account.
> 
> Fixes: 9a9eb104edf6 ("ethdev: parse multiple representor devargs")
> Signed-off-by: Thierry Herbelot <thierry.herbelot at 6wind.com>
> Signed-off-by: Olivier Matz <olivier.matz at 6wind.com>
>

Thanks for the fix,
Reviewed-by: Ferruh Yigit <ferruh.yigit at amd.com>


Applied to dpdk-next-net/main, thanks.


Patch title and commit log updated as following while merging:
```
ethdev: fix uninitialised representor devargs

rte_eth_devargs_parse() stops initialising eth_devargs variable to zero,
which causes regression in ixgbe PCI probe.

Restore the memset for fix.

As the listed commit introduces a new argument: nb_da, the memset
takes it into account.

Fixes: 9a9eb104edf6 ("ethdev: parse multiple representor devargs")
```


More information about the dev mailing list