[PATCH 0/4] Virtio-user queues setup fixes

David Marchand david.marchand at redhat.com
Wed Mar 27 11:04:01 CET 2024


Hello Maxime,

On Wed, Mar 27, 2024 at 10:40 AM Maxime Coquelin
<maxime.coquelin at redhat.com> wrote:
>
> This series aims at fixing several issues found in
> Virtio-user PMD related to queues setup and cleanup.
>
> It has been tested with Vhost-vDPA backend using Nvidia
> Cx6-Dx vDPA VF.
>
> First patch in the series renames the queues iterator
> helper, so it is not a fix. But I would suggest to have it
> backported to ease backporting of the fixes.
>
> Maxime Coquelin (4):
>   net/virtio: rename Virtio-user queue iterator
>   net/virtio: use iterator to destroy Virtio-user queues
>   net/virtio: fix shadow control queue notification init
>   net/virtio: fix shadow control queue allocation
>
>  .../net/virtio/virtio_user/virtio_user_dev.c  | 132 +++++++++---------
>  1 file changed, 67 insertions(+), 65 deletions(-)

I would prefix those titles with net/virtio-user: as was done in the past.
This will show the changes only affect virtio-user.

For patch 2, it is better to highlight the functional change/fix in
the title, so something like:
net/virtio-user: fix control queue destruction

With this fixed, you can add on the series:
Acked-by: David Marchand <david.marchand at redhat.com>


-- 
David Marchand



More information about the dev mailing list