[dts] [PATCH v2 05/19] Add a module to instantiate the VM

[Jiajia, SunX]

> -----Original Message-----
> From: Qiu, Michael
> Sent: Tuesday, May 26, 2015 5:07 PM
> To: Jiajia, SunX; dts at dpdk.org
> Subject: Re: [dts] [PATCH v2 05/19] Add a module to instantiate the VM
> 
> On 5/25/2015 5:14 PM, Jiajia, SunX wrote:
> > Hi Michael,
> >
> > Please see the comments below.
> >
> >> -----Original Message-----
> >> From: Qiu, Michael
> >> Sent: Monday, May 25, 2015 2:11 PM
> >> To: Jiajia, SunX; dts at dpdk.org
> >> Subject: Re: [dts] [PATCH v2 05/19] Add a module to instantiate the
> VM
> >>
> >> On 5/22/2015 5:04 PM, Jiajia, Sun wrote:
> >>> From: sjiajiax <sunx.jiajia at intel.com>
> 
> ...
> 
> >>> +        return 1
> >>> +
> >>> +    def check_ports_available(self, pci_bus, pci_id):
> >>> +        """
> >>> +        Check that whether auto scanned ports ready to use
> >>> +        """
> >>> +        pci_addr = "%s:%s" % (pci_bus, pci_id)
> >>> +        if pci_id == "8086:100e":
> >>> +            return False
> >> Why here return false? better to give some comments.
> >>
> >> Also pci_id here should be pci_addr I think.
> > Because the e1000 network is commonly the control port for tester,
> > So it will be ignored defaultly.
> 
> Does pci_addr needed here? It do nothing.

Yes, it does nothing, it should be removed, I will change it next version.

> 
> Thanks,
> Michael
> >
> >>> +        return True
> >>> +
> >>> +    def scan_ports(self):
> >>> +        """
> >>> +        Scan ports information, for vm will always scan
> >>> +        """
> >>> +        self.scan_ports_uncached()
> >>> +
> >>> +    def scan_ports_uncached(self):
> >>> +        """
> >>> +        Scan ports and collect port's pci id, mac adress, ipv6
> >>
> >