[dts] [DTS][PATCH] fix dut port config bug: numa is int, does not have lower attr Changes to be committed: modified: framework/dut.py

Liu, Yong yong.liu at intel.com
Mon Nov 23 07:44:58 CET 2015


Applied. Thanks.

On 11/13/2015 02:00 PM, Liu, Yong wrote:
> Hi Jingguo,
> Please add warning when configuration not match real. And please 
> separate comments from email subject.
>
> On 11/13/2015 01:17 PM, Jingguo Fu wrote:
>> Signed-off-by: Jingguo Fu <jingguox.fu at intel.com>
>> ---
>>   framework/dut.py | 5 +++--
>>   1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/framework/dut.py b/framework/dut.py
>> index 70bd146..37d6050 100644
>> --- a/framework/dut.py
>> +++ b/framework/dut.py
>> @@ -775,12 +775,13 @@ class Dut(Crb):
>>                   port_cfg['source'] = 'cfg'
>>               else:
>>                   port_cfg = {}
>> -
>> -            for key in ['intf', 'mac', 'numa', 'peer', 'source']:
>> +            for key in ['intf', 'mac', 'peer', 'source']:
>>                   if key in port_cfg:
>>                       if key in port and port_cfg[key].lower() != 
>> port[key].lower():
>>                           self.logger.warning("CONFIGURED %s NOT SAME 
>> AS SCANNED!!!" % (key.upper()))
>>                       port[key] = port_cfg[key].lower()
>> +            if 'numa' in port_cfg:
>> +                port['numa'] = port_cfg['numa']
> Better to check whether assigned numa matched detected numa. If they 
> are mismatched, just send out the warning like "mac" and other 
> parameters.
>
>>       def map_available_ports(self):
>>           """
>



More information about the dts mailing list