[dts] [PATCH] Add RRC support for shutdown_api

Qiu, Michael michael.qiu at intel.com
Tue Oct 20 10:14:05 CEST 2015


On 2015/10/20 10:34, Xu, HuilongX wrote:
> Hi Michael,
> Pls see my comments as below.
> Thanks  a lot
>>

[../..]

>> self.tester.scapy_append('sendp([Ether(dst="%s")/Dot1Q(vlan=1)/IP()/Raw(lo
>> ad="\x50"*%s)], iface="%s")' % (mac, padding, itf))
>>> +            if pktSize <= 64:
>>> +                pktSize=68
> Why pktsize minimum is 68, RRC nic minimum pktsize is 68?

Not yet, because one vlan packet is 68 bytes right?

Thanks,
Michael

[../..]

>>>      def test_change_linkspeed(self):
>>>          """
>>>          Change Link Speed.
>>>          """
>>> +        if self.nic == "redrockcanyou":
>>> +            print dts.RED("RRC not support\n")
>>> +            return
>>> +
> You shoud add this case in check_case_list.xlsx for skip RRC test.

I will add it in other patch.


>>>          self.pmdout.start_testpmd("Default", "--portmask=%s" %
>> dts.create_mask(self.ports), socket=self.ports_socket)
>>>
>



More information about the dts mailing list