[dts] [PATCH V1] fix IndexError on FreeBSD

Liu, Yong yong.liu at intel.com
Tue Nov 29 02:09:30 CET 2016


Hi Gang,
The execution sequence should be scan/restore/rescan, you can try to simplify it to restore/scan. 
But if u changed default logic, it need to be validated on all platforms and even for virtual machine.
For this issue, you can simplify the fix by just fix IndexError in function scan_ports_uncached_freebsd. 
Thus there will be no side-effect need to be checked. 

Thanks,
Marvin

> -----Original Message-----
> From: dts [mailto:dts-bounces at dpdk.org] On Behalf Of xu,gang
> Sent: Monday, November 28, 2016 5:16 PM
> To: dts at dpdk.org
> Cc: Xu, GangX
> Subject: [dts] [PATCH V1] fix IndexError on FreeBSD
> 
> On FreeBSD scan ports use "pciconf -l" get interface name,
> if not restore interfaces before scan ports,
> it can't get right interface,dpdk change them use nic_uio,
> so dts show "IndexError: list index out of range"
> 
> Signed-off-by: xu,gang <gangx.xu at intel.com>
> ---
>  framework/dut.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/framework/dut.py b/framework/dut.py
> index c8a3fe4..f64d4e6 100644
> --- a/framework/dut.py
> +++ b/framework/dut.py
> @@ -187,10 +187,10 @@ class Dut(Crb):
>          self.pci_devices_information()
>          # make sure ipv6 enable before scan
>          self.enable_tester_ipv6()
> -        # scan ports before restore interface
> -        self.scan_ports()
>          # restore dut ports to kernel
>          self.restore_interfaces()
> +        # scan ports before restore interface
> +        self.scan_ports()
>          # rescan ports after interface up
>          self.rescan_ports()
>          # load port infor from config file
> --
> 1.9.3



More information about the dts mailing list