[dts] [PATCH] tests/hotplug: fix some failure cases

[Jianbo Liu]

On 16 October 2017 at 18:22, Phil Yang <phil.yang at arm.com> wrote:
> 1. Updated testpmd path for multiarch.
> 2. Fix port binding timeout in tear-down process.
> 3. Modified acceptance criteria to avoid test errors caused by
> broadcast packets.
>
> Signed-off-by: Phil Yang <phil.yang at arm.com>
> ---
>  tests/TestSuite_hotplug.py | 17 ++++++++++-------
>  1 file changed, 10 insertions(+), 7 deletions(-)
>
> diff --git a/tests/TestSuite_hotplug.py b/tests/TestSuite_hotplug.py
> index 7704253..99d3f3b 100644
> --- a/tests/TestSuite_hotplug.py
> +++ b/tests/TestSuite_hotplug.py
> @@ -69,8 +69,8 @@ class TestPortHotPlug(TestCase):
>          """
>          attach port
>          """
> -        # dpdk hotplug discern NIC by pci bus not include domid
> -        self.dut.send_expect("port attach %s" % self.dut.ports_info[port]['pci'][len("0000:"):],"is attached",60)
> +        # dpdk hotplug discern NIC by pci bus and include domid
> +        self.dut.send_expect("port attach %s" % self.dut.ports_info[port]['pci'],"is attached",60)
>          self.dut.send_expect("port start %s" % port,"Configuring Port",120)
>          # sleep 10 seconds for fortville update link stats
>          time.sleep(10)
> @@ -90,7 +90,7 @@ class TestPortHotPlug(TestCase):
>          """
>          first run testpmd after attach port
>          """
> -        cmd = "./x86_64-native-linuxapp-gcc/app/testpmd -c %s -n %s -- -i" % (self.coremask,self.dut.get_memory_channels())
> +        cmd = "./%s/app/testpmd -c %s -n %s -- -i" % (self.target,self.coremask,self.dut.get_memory_channels())
>          self.dut.send_expect(cmd,"testpmd>",60)
>          session_secondary = self.dut.new_session()
>          session_secondary.send_expect("./usertools/dpdk-devbind.py --bind=igb_uio %s" % self.dut.ports_info[self.port]['pci'], "#", 60)
> @@ -104,11 +104,12 @@ class TestPortHotPlug(TestCase):
>
>          self.dut.send_expect("start","testpmd>",60)
>          self.dut.send_expect("port detach %s" % self.port,"Please close port first",60)
> +        self.dut.send_expect("clear port stats %s" % self.port ,"testpmd>",60)
>          self.send_packet(self.port)
>          out = self.dut.send_expect("show port stats %s" % self.port ,"testpmd>",60)
>          packet = re.search("RX-packets:\s*(\d*)",out)
>          sum_packet = packet.group(1)
> -        self.verify(int(sum_packet) == 1, "Insufficient the received package")
> +        self.verify(int(sum_packet) > 0, "Insufficient the received package")

Maybe it's environment issue, you should still check the packet number == 1.

>          self.dut.send_expect("quit","#",60)
>
>      def send_packet(self, port):
> @@ -129,17 +130,19 @@ class TestPortHotPlug(TestCase):
>          session_secondary = self.dut.new_session()
>          session_secondary.send_expect("./usertools/dpdk-devbind.py --bind=igb_uio %s" % self.dut.ports_info[self.port]['pci'], "#", 60)
>          self.dut.close_session(session_secondary)
> -        cmd = "./x86_64-native-linuxapp-gcc/app/testpmd -c %s -n %s -- -i" % (self.coremask,self.dut.get_memory_channels())
> +        cmd = "./%s/app/testpmd -c %s -n %s -- -i" % (self.target,self.coremask,self.dut.get_memory_channels())
>          self.dut.send_expect(cmd,"testpmd>",60)
>          self.detach(self.port)
>          self.attach(self.port)
> +
>          self.dut.send_expect("start","testpmd>",60)
>          self.dut.send_expect("port detach %s" % self.port, "Please close port first",60)
> +        self.dut.send_expect("clear port stats %s" % self.port ,"testpmd>",60)
>          self.send_packet(self.port)
>          out = self.dut.send_expect("show port stats %s" % self.port ,"testpmd>",60)
>          packet = re.search("RX-packets:\s*(\d*)",out)
>          sum_packet = packet.group(1)
> -        self.verify(int(sum_packet) == 1, "Insufficient the received package")
> +        self.verify(int(sum_packet) > 0, "Insufficient the received package")
>          self.dut.send_expect("quit","#",60)
>
>
> @@ -147,8 +150,8 @@ class TestPortHotPlug(TestCase):
>          """
>          Run after each test case.
>          """
> -        self.dut.send_expect("./usertools/dpdk-devbind.py --bind=igb_uio %s" % self.dut.ports_info[self.port]['pci'],"#",60)
>          self.dut.kill_all()
> +        self.dut.send_expect("./usertools/dpdk-devbind.py --bind=igb_uio %s" % self.dut.ports_info[self.port]['pci'],"#",60)

I think you should consider vfio-pci as well.

>          time.sleep(2)
>
>
> --
> 2.7.4
>