[dts] [PATCH] tests/vhost_user_live_migration: Optimize for multi-platform.
Liu, Yong
yong.liu at intel.com
Tue Jan 9 07:43:52 CET 2018
You're welcome, Phil.
> -----Original Message-----
> From: Phil Yang [mailto:Phil.Yang at arm.com]
> Sent: Tuesday, January 09, 2018 2:16 PM
> To: Liu, Yong <yong.liu at intel.com>; dts at dpdk.org
> Cc: nd <nd at arm.com>
> Subject: RE: [PATCH] tests/vhost_user_live_migration: Optimize for multi-
> platform.
>
> Hi Marvin
>
> Thanks for your comments. Updated.
>
> Thanks,
> Phil Yang
>
> > -----Original Message-----
> > From: Liu, Yong [mailto:yong.liu at intel.com]
> > Sent: Tuesday, January 9, 2018 9:10 PM
> > To: Phil Yang <Phil.Yang at arm.com>; dts at dpdk.org
> > Cc: nd <nd at arm.com>
> > Subject: Re: [PATCH] tests/vhost_user_live_migration: Optimize for
> multi-
> > platform.
> >
> > Phil,
> > There's one comment as below.
> >
> > On 01/05/2018 06:29 PM, Phil Yang wrote:
> > > +
> > > + dirct_pat = re.compile(r"(\s+)\[ (\S+) in\|out\|inout \]")
> > > + vm_dut.send_expect("tcpdump -h", "# ")
> > > + out = vm_dut.get_session_output(timeout=1)
> > > + m = dirct_pat.search(out)
> > > + if m:
> > > + dirct_para = "-" + m.group(2)[1] + " in"
> > > + else:
> > > + dirct_para = ""
> > > +
> >
> > Please change variable name to more meaning full name "direct_param".
> >
> > Thanks,
> > Marvin
More information about the dts
mailing list