[dts] [PATCH 1/2] tests/vf_packet_rxtx: fix test case failures in vf_reset

Liu, Yong yong.liu at intel.com
Mon Mar 12 02:38:49 CET 2018


Joyce,
There's still some kind of possibility that PF will transmit packets in the test which will cause unexpected result.
It's better to disable network-manager on the PF device. But if this solution is workable for you, I can also merge it.

Thanks,
Marvin

> -----Original Message-----
> From: Joyce Kong [mailto:Joyce.Kong at arm.com]
> Sent: Friday, March 09, 2018 7:39 PM
> To: Liu, Yong <yong.liu at intel.com>; dts at dpdk.org
> Subject: RE: [dts] [PATCH 1/2] tests/vf_packet_rxtx: fix test case
> failures in vf_reset
> 
> Hi Marvin,
> 
> DUT PF would send dhcp protocol packet to VF before tester transmission,
> and that's why we need to clear ports  at the start.
> 
> Best Regards,
> Joyce
> 
> -----Original Message-----
> From: Liu, Yong [mailto:yong.liu at intel.com]
> Sent: Thursday, March 8, 2018 11:37 AM
> To: Joyce Kong <Joyce.Kong at arm.com>; dts at dpdk.org
> Cc: Zhao, MeijuanX <meijuanx.zhao at intel.com>
> Subject: RE: [dts] [PATCH 1/2] tests/vf_packet_rxtx: fix test case
> failures in vf_reset
> 
> Hi Joyce,
> Could you please figure out why need to clean the counter before tester
> transmission? It should be no packet sent to VF before that moment.
> 
> Thanks,
> Marvin
> 
> > -----Original Message-----
> > From: dts [mailto:dts-bounces at dpdk.org] On Behalf Of Joyce Kong
> > Sent: Tuesday, March 06, 2018 3:47 PM
> > To: dts at dpdk.org
> > Cc: Joyce Kong <joyce.kong at arm.com>
> > Subject: [dts] [PATCH 1/2] tests/vf_packet_rxtx: fix test case
> > failures in vf_reset
> >
> > Clear port stats before counting port info
> >
> > Signed-off-by: Joyce Kong <joyce.kong at arm.com>
> > ---
> >  tests/TestSuite_vf_packet_rxtx.py | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/tests/TestSuite_vf_packet_rxtx.py
> > b/tests/TestSuite_vf_packet_rxtx.py
> > index 63f4820..6a29d23 100644
> > --- a/tests/TestSuite_vf_packet_rxtx.py
> > +++ b/tests/TestSuite_vf_packet_rxtx.py
> > @@ -279,6 +279,7 @@ class TestVfPacketRxtx(TestCase):
> >          rx_port = tx_port
> >
> >          dst_mac = pmd0_vf0_mac
> > +        self.vm0_testpmd.execute_cmd('clear port stats all')
> >          self.tester.sendpkt_bg(tx_port, dst_mac)
> >
> >          #vf port stop/start can trigger reset action
> > --
> > 1.8.3.1
> 
> IMPORTANT NOTICE: The contents of this email and any attachments are
> confidential and may also be privileged. If you are not the intended
> recipient, please notify the sender immediately and do not disclose the
> contents to any other person, use it for any purpose, or store or copy the
> information in any medium. Thank you.


More information about the dts mailing list