[dts] [PATCH V2] tests/shutdown_api: check crc strip bit instead of Rx offloads to verify CRC is enabled or not

wenjieli wenjiex.a.li at intel.com
Tue Oct 23 07:14:12 CEST 2018


If crc strip enabled, the crc strip bit (bit 12) is 0, else it is 1.
Use this bit to check crc is enabled or not, will not just check the Rx
offloads value in output.

Signed-off-by: wenjieli <wenjiex.a.li at intel.com>
---
 tests/TestSuite_shutdown_api.py | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/tests/TestSuite_shutdown_api.py b/tests/TestSuite_shutdown_api.py
index 52a8fbf..decd9a7 100644
--- a/tests/TestSuite_shutdown_api.py
+++ b/tests/TestSuite_shutdown_api.py
@@ -263,6 +263,8 @@ class TestShutdownApi(TestCase):
         """
         Reconfigure All Ports With The Same Configurations (CRC)
         """
+        RX_OFFLOAD_KEEP_CRC = 0x1000
+        CRC_Strip_bit = 0
         self.pmdout.start_testpmd("Default", "--portmask=%s --port-topology=loop --disable-crc-strip" % utils.create_mask(self.ports), socket=self.ports_socket)
         out = self.dut.send_expect("show config rxtx", "testpmd> ")
         self.verify(
@@ -273,8 +275,10 @@ class TestShutdownApi(TestCase):
         self.dut.send_expect("set fwd mac", "testpmd>")
         self.dut.send_expect("port start all", "testpmd> ", 100)
         out = self.dut.send_expect("show config rxtx", "testpmd> ")
+        Rx_offloads = re.compile('Rx offloads=(.*?)\s+?').findall(out, re.S)
         self.verify(
-            "Rx offloads=0x1000" in out, "CRC stripping not enabled properly")
+            RX_OFFLOAD_KEEP_CRC & int(Rx_offloads[0],16) == CRC_Strip_bit and RX_OFFLOAD_KEEP_CRC & int(Rx_offloads[1],16) == CRC_Strip_bit,
+            "CRC stripping not enabled properly")
         self.dut.send_expect("start", "testpmd> ")
         self.check_forwarding()
 
-- 
2.17.2



More information about the dts mailing list