[dts] [PATCH] add execution new ipsec lib

Tu, Lijuan lijuan.tu at intel.com
Tue Apr 16 19:22:18 CEST 2019


Agree with Rami

> -----Original Message-----
> From: dts [mailto:dts-bounces at dpdk.org] On Behalf Of Rami Rosen
> Sent: Monday, April 15, 2019 10:07 PM
> To: Xu, Yanjie <yanjie.xu at intel.com>; dts at dpdk.org
> Subject: Re: [dts] [PATCH] add execution new ipsec lib
> 
> Hi, Xuyanjie,
> 
> You have:
> >+[Execution1]
> >+crbs=10.67.110.186
> >+drivername=igb_uio
> 
> If you will run from the executions folder:
> git grep "crbs=" .
> 
> You will get:
> 
> execution.cfg:crbs=<CRB IP Address>
> execution.cfg:crbs=<Performance CRB IP Address>
> execution_FVL.cfg:crbs=<CRB IP Address>
> execution_FVL.cfg:crbs=<Performance CRB IP Address>
> execution_fm10k.cfg:crbs=<CRB IP Address>
> execution_fm10k.cfg:crbs=<Performance CRB IP Address>
> execution_rxmode.cfg:crbs=<CRB IP Address>
> execution_rxmode.cfg:crbs=<CRB IP Address>
> execution_rxmode.cfg:crbs=<CRB IP Address>
> execution_smoke.cfg:crbs=<CRB IP Address>
> 
> IMHO, there is no justification to an exception of having a specific IP address
> like 10.67.110.186, as in your patch, instead of having <CRB IP Address>, like
> all the others execution files, as shown above.
> 
> Regards,
> Rami Rosen



More information about the dts mailing list