[dts] [PATCH 08/17] tests/TestSuite_ipgre: add carlsville to support nic of ipgre
Fu, Qi
qi.fu at intel.com
Mon Aug 19 07:23:34 CEST 2019
Hi,
Lijuan has reviewed these patchese and I have verified them before.
If use 'self.nic.startswith("fortville" or "carlsville")' it can't work, but use 'self.nic.startswith("fortville" and "carlsville")' works well.
Best regards,
Fu, Qi
-----Original Message-----
From: Mo, YufengX
Sent: Monday, August 19, 2019 1:06 PM
To: Fu, Qi <qi.fu at intel.com>; dts at dpdk.org
Cc: Fu, Qi <qi.fu at intel.com>
Subject: RE: [dts] [PATCH 08/17] tests/TestSuite_ipgre: add carlsville to support nic of ipgre
Have your leader review your source code? Below checking syntax is wrong
> -----Original Message-----
> From: dts [mailto:dts-bounces at dpdk.org] On Behalf Of qifu
> Sent: Monday, August 19, 2019 7:06 PM
> To: dts at dpdk.org
> Cc: Fu, Qi <qi.fu at intel.com>
> Subject: [dts] [PATCH 08/17] tests/TestSuite_ipgre: add carlsville to
> support nic of ipgre
>
> Add carlsville to support nic of ipgre.
> Signed-off-by: qifu <qi.fu at intel.com>
> ---
> tests/TestSuite_ipgre.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/TestSuite_ipgre.py b/tests/TestSuite_ipgre.py index
> 6f465fa..04fd651 100644
> --- a/tests/TestSuite_ipgre.py
> +++ b/tests/TestSuite_ipgre.py
> @@ -63,7 +63,7 @@ class TestIpgre(TestCase):
> """
> self.printFlag = self._enable_debug
> ports = self.dut.get_ports()
> - self.verify(self.nic.startswith("fortville"),
> + self.verify(self.nic.startswith("fortville" and
> + "carlsville"),
> "GRE tunnel packet type only support by Fortville")
> self.verify(len(ports) >= 1, "Insufficient ports for testing")
> valports = [_ for _ in ports if self.tester.get_local_port(_)
> != -1]
> --
> 2.17.1
More information about the dts
mailing list