[dts] [PATCH V1] tests/tx_preparation: optimize script

Yao, BingX Y bingx.y.yao at intel.com
Fri Aug 23 10:24:12 CEST 2019


Tested-by:Yao, BingX Y <bingx.y.yao at intel.com>

-----Original Message-----
From: dts [mailto:dts-bounces at dpdk.org] On Behalf Of Wenjie Li
Sent: Saturday, August 24, 2019 1:03 AM
To: dts at dpdk.org
Cc: Li, WenjieX A <wenjiex.a.li at intel.com>
Subject: [dts] [PATCH V1] tests/tx_preparation: optimize script

move stop/quit testpmd into tear_down; otherwise, if one case is failed, the testpmd is still running, it will affect the following cases.

Signed-off-by: Wenjie Li <wenjiex.a.li at intel.com>
---
 tests/TestSuite_tx_preparation.py | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/tests/TestSuite_tx_preparation.py b/tests/TestSuite_tx_preparation.py
index eea95c1..ba0aac7 100644
--- a/tests/TestSuite_tx_preparation.py
+++ b/tests/TestSuite_tx_preparation.py
@@ -173,8 +173,6 @@ class TestTX_preparation(TestCase):
         self.dut_testpmd.execute_cmd('start')
 
         self.send_packet_verify()
-        self.dut_testpmd.execute_cmd('stop')
-        self.dut_testpmd.quit() 
  
     def test_tx_preparation_TSO(self):
         """
@@ -185,16 +183,13 @@ class TestTX_preparation(TestCase):
         self.dut_testpmd.execute_cmd('start')
 
         self.send_packet_verify(1)
-        self.dut_testpmd.execute_cmd('stop')
-        self.dut_testpmd.quit()
-
 
     def tear_down(self):
         """
         Run after each test case. 
-        """ 
-        pass
-
+        """
+        self.dut_testpmd.execute_cmd('stop')
+        self.dut_testpmd.quit()
         
     def tear_down_all(self):
         """
--
2.17.1

-------------- next part --------------
A non-text attachment was scrubbed...
Name: TestTX_preparation.log
Type: application/octet-stream
Size: 55884 bytes
Desc: TestTX_preparation.log
URL: <http://mails.dpdk.org/archives/dts/attachments/20190823/e9fb1b3d/attachment.obj>


More information about the dts mailing list