[dts] [PATCH] conf/test_case_supportlist.json: Avoid showing fail for not supported NICs

[Phanendra Vukkisala]

Hi Lijuan,


I can add these tests in "test_case_checklist.json" as these are not supported on cavium devices.

But in the test scripts, I can see the tests are supported only on few NICs I have mentioned in supportlist.json


For instance: the syn_filter test is supported by Niantic, kawela_4, bartonhills, powerville. I have taken this reference from test scripts.

Below is test script snippet, because of verifying inside test case the result of test is showing as Failed instead of Not Applicable for other NICs.


    def test_syn_filter(self):
        """
        Enable receipt of SYN packets
        """
        self.verify(self.nic in ["niantic", "kawela_4", "bartonhills", "powerville"], "%s nic not support syn filter" % self.nic)



If you fell I should update in "test_case_checklist.json" for cavium device only, please let me know I will do the same.


Regards,

Phanendra

________________________________
From: Tu, Lijuan <lijuan.tu at intel.com>
Sent: Monday, January 7, 2019 2:13:59 PM
To: Phanendra Vukkisala; dts at dpdk.org
Cc: Vijaya Bhaskar Annayyolla; Faisal Masood
Subject: [EXT] RE: [PATCH] conf/test_case_supportlist.json: Avoid showing fail for not supported NICs

External Email

----------------------------------------------------------------------
Hi phanendra,

If test cases are not supported by some NICs, I should be added into test_case_checklist.json.
Only the cases that added in supportlist.json are supported by these specific NICs.

For instance: the syn_filter you added in the support list.
Syn_filter is only supported by Niantic, kawela_r, bartonhills, powerville, but not supported by Fortville and other NICes.

"syn_filter": [
> +        {
> +            "OS": [
> +                "ALL"
> +            ],
> +            "NIC": [
> +                "niantic",
> +                "kawela_4",
> +                "bartonhills",
> +                "powerville"
> +            ],
> +            "Target": [
> +                "ALL"
> +            ],
> +            "Bug ID": "",
> +            "Comments": "This case not support on this NIC"
> +        }
> +    ],


> -----Original Message-----
> From: dts [mailto:dts-bounces at dpdk.org] On Behalf Of Phanendra Vukkisala
> Sent: Friday, January 4, 2019 5:00 PM
> To: dts at dpdk.org
> Cc: Vijaya Bhaskar Annayyolla <avijay at marvell.com>; Faisal Masood
> <fmasood at marvell.com>; Phanendra Vukkisala <pvukkisala at marvell.com>
> Subject: [dts] [PATCH] conf/test_case_supportlist.json: Avoid showing fail
> for not supported NICs
>
> From: pvukkisala <pvukkisala at marvell.com>
>
> Result is showing as fail for not supported NICs. Added proper fix to avoid
> show test result as fail instead of N/A.
>
> Signed-off-by: phanendra,vukkisala <pvukkisala at marvell.com>
> ---
>  conf/test_case_supportlist.json |  201
> +++++++++++++++++++++++++++++++++++++++
>  1 file changed, 201 insertions(+)
>
> diff --git a/conf/test_case_supportlist.json
> b/conf/test_case_supportlist.json index 571bb5c..c128c95 100644
> --- a/conf/test_case_supportlist.json
> +++ b/conf/test_case_supportlist.json
> @@ -633,5 +633,206 @@
>              "Bug ID": "",
>              "Comments": "This case only support on FVL"
>          }
> +    ],
> +    "syn_filter": [
> +        {
> +            "OS": [
> +                "ALL"
> +            ],
> +            "NIC": [
> +                "niantic",
> +                "kawela_4",
> +                "bartonhills",
> +                "powerville"
> +            ],
> +            "Target": [
> +                "ALL"
> +            ],
> +            "Bug ID": "",
> +            "Comments": "This case not support on this NIC"
> +        }
> +    ],
> +    "priority_filter": [
> +        {
> +            "OS": [
> +                "ALL"
> +            ],
> +            "NIC": [
> +                "niantic",
> +                "kawela_4",
> +                "bartonhills",
> +                "powerville"
> +            ],
> +            "Target": [
> +                "ALL"
> +            ],
> +            "Bug ID": "",
> +            "Comments": "This case not support on this NIC"
> +        }
> +    ],
> +    "five_tuple_filter": [
> +        {
> +            "OS": [
> +                "ALL"
> +            ],
> +            "NIC": [
> +                "niantic",
> +                "kawela_4"
> +            ],
> +            "Target": [
> +                "ALL"
> +            ],
> +            "Bug ID": "",
> +            "Comments": "This case only support only on Niantic and
> kawela_4"
> +        }
> +    ],
> +    "ethertype_filter": [
> +        {
> +            "OS": [
> +                "ALL"
> +            ],
> +            "NIC": [
> +                "niantic",
> +                "kawela_4",
> +                "bartonhills",
> +                "powerville",
> +                "fortville_eagle",
> +                "fortville_spirit",
> +                "fortville_spirit_single",
> +                "fortpark_TLV",
> +                "fortville_25g"
> +            ],
> +            "Target": [
> +                "ALL"
> +            ],
> +            "Bug ID": "",
> +            "Comments": "This case is not supported on this NIC"
> +        }
> +    ],
> +    "multiple_filters_10GB": [
> +        {
> +            "OS": [
> +                "ALL"
> +            ],
> +            "NIC": [
> +                "niantic"
> +            ],
> +            "Target": [
> +                "ALL"
> +            ],
> +            "Bug ID": "",
> +            "Comments": "This case only support with Niantic NIC"
> +        }
> +    ],
> +    "twotuple_filter": [
> +        {
> +            "OS": [
> +                "ALL"
> +            ],
> +            "NIC": [
> +                "powerville",
> +                "bartonhills"
> +            ],
> +            "Target": [
> +                "ALL"
> +            ],
> +            "Bug ID": "",
> +            "Comments": "This case is not supported on this NIC"
> +        }
> +    ],
> +    "flex_filter": [
> +        {
> +            "OS": [
> +                "ALL"
> +            ],
> +            "NIC": [
> +                "powerville",
> +                "bartonhills"
> +            ],
> +            "Target": [
> +                "ALL"
> +            ],
> +            "Bug ID": "",
> +            "Comments": "This case is not supported on this NIC"
> +        }
> +    ],
> +    "multiple_filters_1GB": [
> +        {
> +            "OS": [
> +                "ALL"
> +            ],
> +            "NIC": [
> +                "powerville",
> +                "kawela_4",
> +                "bartonhills"
> +            ],
> +            "Target": [
> +                "ALL"
> +            ],
> +            "Bug ID": "",
> +            "Comments": "This case is not supported on this NIC"
> +        }
> +    ],
> +    "128_queues": [
> +        {
> +            "OS": [
> +                "ALL"
> +            ],
> +            "NIC": [
> +                "niantic",
> +                "ironpond",
> +                "twinpond",
> +                "twinville",
> +                "sageville",
> +                "sagepond",
> +                "magnolia_park",
> +                "springfountain"
> +            ],
> +            "Target": [
> +                "ALL"
> +            ],
> +            "Bug ID": "",
> +            "Comments": "This case only support with ixgbe driver"
> +        }
> +    ],
> +    "rss_key_size": [
> +        {
> +            "OS": [
> +                "ALL"
> +            ],
> +            "NIC": [
> +                "fortville_eagle",
> +                "fortville_spirit",
> +                "fortville_spirit_single",
> +                "fortville_25g",
> +                "niantic",
> +                "redrockcanyou",
> +                "atwood",
> +                "boulderrapid",
> +                "fortpark_TLV"
> +            ],
> +            "Target": [
> +                "ALL"
> +            ],
> +            "Bug ID": "",
> +            "Comments": "This case is not supported on this NIC"
> +        }
> +    ],
> +    "vlan_qinq_tpid": [
> +        {
> +            "OS": [
> +                "ALL"
> +            ],
> +            "NIC": [
> +                "fortville_eagle",
> +                "fortville_spirit",
> +                "fortville_spirit_single"
> +            ],
> +            "Target": [
> +                "ALL"
> +            ],
> +            "Bug ID": "",
> +            "Comments": "This case is not supported on this NIC"
> +        }
>      ]
>  }
> --
> 1.7.9.5

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mails.dpdk.org/archives/dts/attachments/20190107/e362d874/attachment.html>