[dts] [PATCH V1] tests/pmdrss_hash:change hard code

Tu, Lijuan lijuan.tu at intel.com
Fri Mar 15 07:13:51 CET 2019


Do you forget to change hardcode of memory channel?

> -----Original Message-----
> From: dts [mailto:dts-bounces at dpdk.org] On Behalf Of yaobing
> Sent: Tuesday, March 12, 2019 1:10 PM
> To: dts at dpdk.org
> Cc: Yao, BingX Y <bingx.y.yao at intel.com>
> Subject: [dts] [PATCH V1] tests/pmdrss_hash:change hard code
> 
> change the corelist adapted to the actual cores instead of hard code
> 
> Signed-off-by: yaobing <bingx.y.yao at intel.com>
> ---
>  tests/TestSuite_pmdrss_hash.py | 23 ++++++++++++-----------
>  1 file changed, 12 insertions(+), 11 deletions(-)
> 
> diff --git a/tests/TestSuite_pmdrss_hash.py b/tests/TestSuite_pmdrss_hash.py
> index 60c9819..fc98922 100644
> --- a/tests/TestSuite_pmdrss_hash.py
> +++ b/tests/TestSuite_pmdrss_hash.py
> @@ -464,8 +464,9 @@ class TestPmdrssHash(TestCase):
>          """
>          Run before each test case.
>          """
> -        pass
> -
> +        cores = self.dut.get_core_list("all")
> +        self.coremask = utils.create_mask(cores)
> +
>      def test_toeplitz(self):
>          dutPorts = self.dut.get_ports(self.nic)
>          localPort = self.tester.get_local_port(dutPorts[0])
> @@ -477,8 +478,8 @@ class TestPmdrssHash(TestCase):
> 
>          # test with different rss queues
>          self.dut.send_expect(
> -            "./%s/app/testpmd  -c fffff -n %d -- -i --coremask=0xffffe --rxq=%d --
> txq=%d" %
> -            (self.target, self.dut.get_memory_channels(), queue, queue), "testpmd>
> ", 120)
> +            "./%s/app/testpmd  -c %s -n %d -- -i --rxq=%d --txq=%d" %
> +            (self.target, self.coremask,
> + self.dut.get_memory_channels(), queue, queue), "testpmd> ", 120)
> 
>          for iptype, rsstype in iptypes.items():
>              self.dut.send_expect("set verbose 8", "testpmd> ") @@ -514,8 +515,8
> @@ class TestPmdrssHash(TestCase):
> 
>          # test with different rss queues
>          self.dut.send_expect(
> -            "./%s/app/testpmd  -c fffff -n %d -- -i --coremask=0xffffe --rxq=%d --
> txq=%d" %
> -            (self.target, self.dut.get_memory_channels(), queue, queue), "testpmd>
> ", 120)
> +            "./%s/app/testpmd  -c %s -n %d -- -i --rxq=%d --txq=%d" %
> +            (self.target, self.coremask,
> + self.dut.get_memory_channels(), queue, queue), "testpmd> ", 120)
> 
>          for iptype, rsstype in iptypes.items():
>              self.dut.send_expect("set verbose 8", "testpmd> ") @@ -558,8 +559,8
> @@ class TestPmdrssHash(TestCase):
> 
>          # test with different rss queues
>          self.dut.send_expect(
> -            "./%s/app/testpmd  -c fffff -n %d -- -i --coremask=0xffffe --rxq=%d --
> txq=%d" %
> -            (self.target, self.dut.get_memory_channels(), queue, queue), "testpmd>
> ", 120)
> +            "./%s/app/testpmd  -c %s -n %d -- -i --rxq=%d --txq=%d" %
> +            (self.target, self.coremask,
> + self.dut.get_memory_channels(), queue, queue), "testpmd> ", 120)
> 
>          for iptype, rsstype in iptypes.items():
>              self.logger.info("***********************%s rss
> test********************************" % iptype) @@ -597,8 +598,8 @@
> class TestPmdrssHash(TestCase):
> 
>          # test with different rss queues
>          self.dut.send_expect(
> -            "./%s/app/testpmd  -c fffff -n %d -- -i --coremask=0xffffe --rxq=%d --
> txq=%d" %
> -            (self.target, self.dut.get_memory_channels(), queue, queue), "testpmd>
> ", 120)
> +            "./%s/app/testpmd  -c %s -n %d -- -i --rxq=%d --txq=%d" %
> +            (self.target, self.coremask,
> + self.dut.get_memory_channels(), queue, queue), "testpmd> ", 120)
> 
>          for iptype, rsstype in iptypes.items():
>              self.dut.send_expect("set verbose 8", "testpmd> ") @@ -632,7 +633,7
> @@ class TestPmdrssHash(TestCase):
>                      "fortpark_TLV", "fortville_25g"],
>                      "NIC Unsupported: " + str(self.nic))
> 
> -        self.dut.send_expect("./%s/app/testpmd -c f -n 4 -- -i" % self.target,
> "testpmd> ", 120)
> +        self.dut.send_expect("./%s/app/testpmd -c %s -n 4 -- -i" %
> + (self.target, self.coremask), "testpmd> ", 120)
[Lijuan] Do you forget to change hardcode of memory channel?
>          out = self.dut.send_expect("create bonded device 3 0", "testpmd> ", 30)
>          bond_device_id = int(re.search("port \d+", out).group().split(" ")[-1].strip())
> 
> --
> 2.17.2



More information about the dts mailing list