[dts] [PATCH V1] tests/shutdown_api:test_change_linkspeed add judgment range to suit CVL 100G

Tu, Lijuan lijuan.tu at intel.com
Fri Nov 22 07:32:33 CET 2019


Hi xiaoxiao,

It's not difficult to have regex to suit for both condition, could you please to optimize the regex, thanks

result_scanner = r"([0-9]+)baseSR4/([A-Za-z]+)"
result_scanner = r"([0-9]+)baseT/([A-Za-z]+)"

> -----Original Message-----
> From: dts [mailto:dts-bounces at dpdk.org] On Behalf Of Xiaoxiao Zeng
> Sent: Thursday, November 21, 2019 5:35 AM
> To: dts at dpdk.org
> Cc: Zeng, XiaoxiaoX <xiaoxiaox.zeng at intel.com>
> Subject: [dts] [PATCH V1] tests/shutdown_api:test_change_linkspeed add
> judgment range to suit CVL 100G
> 
> *.to suit CVL 100G.
> 
> Signed-off-by: Xiaoxiao Zeng <xiaoxiaox.zeng at intel.com>
> ---
>  tests/TestSuite_shutdown_api.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_shutdown_api.py
> b/tests/TestSuite_shutdown_api.py index 63fff84..f0a4eea 100644
> --- a/tests/TestSuite_shutdown_api.py
> +++ b/tests/TestSuite_shutdown_api.py
> @@ -317,7 +317,7 @@ class TestShutdownApi(TestCase):
> 
>          out = self.tester.send_expect(
>              "ethtool %s" %
> self.tester.get_interface(self.tester.get_local_port(self.ports[0])), "# ")
> -        if 'fortville_spirit' == self.nic:
> +        if 'fortville_spirit' == self.nic or 'columbiaville_100g' == self.nic:
>              result_scanner = r"([0-9]+)baseSR4/([A-Za-z]+)"
>          else:
>              result_scanner = r"([0-9]+)baseT/([A-Za-z]+)"
> --
> 2.17.0



More information about the dts mailing list