[dts] [PATCH V1] tests/ipgre: optimize script

Zhang, YanX A yanx.a.zhang at intel.com
Mon Sep 9 04:36:54 CEST 2019


Tested-by:  Zhang, YanX A <yanx.a.zhang at intel.com>

Notes: One case failed due to a bug. The bug ID is 15071

-----Original Message-----
From: dts [mailto:dts-bounces at dpdk.org] On Behalf Of Wenjie Li
Sent: Saturday, September 7, 2019 2:43 AM
To: dts at dpdk.org
Cc: Li, WenjieX A <wenjiex.a.li at intel.com>
Subject: [dts] [PATCH V1] tests/ipgre: optimize script

1. could support cvl nic, add cvl to nic list 2. move dut.kill_all from tear_down_all to tear_down, since testpmd will be started in every case, if one case is failed, the testpmd is still runnning, this will affect the following cases.

Signed-off-by: Wenjie Li <wenjiex.a.li at intel.com>
---
 tests/TestSuite_ipgre.py | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/tests/TestSuite_ipgre.py b/tests/TestSuite_ipgre.py index 7fbddf1..e10b0e0 100644
--- a/tests/TestSuite_ipgre.py
+++ b/tests/TestSuite_ipgre.py
@@ -63,7 +63,7 @@ class TestIpgre(TestCase):
         """
         self.printFlag = self._enable_debug
         ports = self.dut.get_ports()
-        self.verify(self.nic in ["fortville_eagle", "fortville_spirit", "fortville_spirit_single", "fortville_25g", "carlsville"],
+        self.verify(self.nic in ["fortville_eagle", "fortville_spirit", 
+ "fortville_spirit_single", "fortville_25g", "carlsville", 
+ "columbiaville_25g", "columbiaville_100g"],
                     "GRE tunnel packet type only support by fortville and carlsville")
         self.verify(len(ports) >= 1, "Insufficient ports for testing")
         valports = [_ for _ in ports if self.tester.get_local_port(_) != -1] @@ -439,12 +439,11 @@ class TestIpgre(TestCase):
         Run after each test case.
         Nothing to do.
         """
-        pass
+        self.dut.kill_all()
 
     def tear_down_all(self):
         """
         Run after each test suite.
         Nothing to do.
         """
-        self.dut.kill_all()
         pass
--
2.17.1

-------------- next part --------------
A non-text attachment was scrubbed...
Name: TestIpgre.log
Type: application/octet-stream
Size: 85292 bytes
Desc: TestIpgre.log
URL: <http://mails.dpdk.org/archives/dts/attachments/20190909/f8e6f807/attachment.obj>


More information about the dts mailing list