[dts] [PATCH V2] tests/cvl_advanced_iavf_rss_gtpu: set vlan id for vf

[Tu, Lijuan]

> -----Original Message-----
> From: dts <dts-bounces at dpdk.org> On Behalf Of sunqin
> Sent: 2021年3月30日 22:47
> To: dts at dpdk.org
> Cc: Sun, QinX <qinx.sun at intel.com>
> Subject: [dts] [PATCH V2] tests/cvl_advanced_iavf_rss_gtpu: set vlan id for vf
> 
> Confirm with developer that the design of dpdk is changed for VF, the VLAN ID
> needs to be set before VF receives VLAN packets.
> 
> Signed-off-by: sunqin <qinx.sun at intel.com>
> ---
> v1: add vlan id in a common function,will be called by most of cases
> v2: add vlan id only for related cases
> 
>  tests/TestSuite_cvl_advanced_iavf_rss_gtpu.py | 26 +++++++++++++++++++
>  1 file changed, 26 insertions(+)
>  mode change 100755 => 100644
> tests/TestSuite_cvl_advanced_iavf_rss_gtpu.py
> 
> diff --git a/tests/TestSuite_cvl_advanced_iavf_rss_gtpu.py
> b/tests/TestSuite_cvl_advanced_iavf_rss_gtpu.py
> old mode 100755
> new mode 100644
> index 6490dcbf..3a679178
> --- a/tests/TestSuite_cvl_advanced_iavf_rss_gtpu.py
> +++ b/tests/TestSuite_cvl_advanced_iavf_rss_gtpu.py
> @@ -8678,34 +8678,60 @@ class TestCVLAdvancedIAVFRSSGTPU(TestCase):
>      # vf rss gtpc gtpu
>      def test_mac_ipv4_gtpu(self):
>          self.switch_testpmd(symmetric=False)
> +        self.pmd_output.execute_cmd('vlan set filter on 0')
> +        self.pmd_output.execute_cmd('rx_vlan add 1 0')
> +        self.pmd_output.execute_cmd('rx_vlan add 3 0')
> +        self.pmd_output.execute_cmd('rx_vlan add 5 0')

Add vlan id in every related test cases, but never remove them, in the following cases the setting is still valid.

For example, add vlan id 1, 3, 5 in test case #1, when running test case #2 the setting is still there.

Could you please consider what's the best way to achieve your target and least impact to other cases.

> 
> self.rssprocess.handle_rss_distribute_cases(cases_info=mac_ipv4_gtpu_toeplitz)
> 
>      def test_mac_ipv6_gtpu(self):
>          self.switch_testpmd(symmetric=False)
> +        self.pmd_output.execute_cmd('vlan set filter on 0')
> +        self.pmd_output.execute_cmd('rx_vlan add 1 0')
> +        self.pmd_output.execute_cmd('rx_vlan add 5 0')
> +        self.pmd_output.execute_cmd('rx_vlan add 7 0')
> +
> 
> self.rssprocess.handle_rss_distribute_cases(cases_info=mac_ipv6_gtpu_toeplitz)
> 
>      def test_mac_ipv4_gtpc(self):
>          self.switch_testpmd(symmetric=False)
> +        self.pmd_output.execute_cmd('vlan set filter on 0')
> +        self.pmd_output.execute_cmd('rx_vlan add 1 0')
> +        self.pmd_output.execute_cmd('rx_vlan add 3 0')
> +        self.pmd_output.execute_cmd('rx_vlan add 5 0')
> 
> self.rssprocess.handle_rss_distribute_cases(cases_info=mac_ipv4_gtpc_toeplitz)
> 
>      def test_mac_ipv6_gtpc(self):
>          self.switch_testpmd(symmetric=False)
> +        self.pmd_output.execute_cmd('vlan set filter on 0')
> +        self.pmd_output.execute_cmd('rx_vlan add 1 0')
> +        self.pmd_output.execute_cmd('rx_vlan add 5 0')
> +        self.pmd_output.execute_cmd('rx_vlan add 3 0')
> 
> self.rssprocess.handle_rss_distribute_cases(cases_info=mac_ipv6_gtpc_toeplitz)
> 
>      def test_mac_ipv4_gtpu_symmetric(self):
>          self.switch_testpmd(symmetric=True)
> +        self.pmd_output.execute_cmd('vlan set filter on 0')
> +        self.pmd_output.execute_cmd('rx_vlan add 1 0')
> 
> self.rssprocess.handle_rss_distribute_cases(cases_info=mac_ipv4_gtpu_symmet
> ric_toeplitz)
> 
>      def test_mac_ipv6_gtpu_symmetric(self):
>          self.switch_testpmd(symmetric=True)
> +        self.pmd_output.execute_cmd('vlan set filter on 0')
> +        self.pmd_output.execute_cmd('rx_vlan add 1 0')
> 
> self.rssprocess.handle_rss_distribute_cases(cases_info=mac_ipv6_gtpu_symmet
> ric_toeplitz)
> 
>      def test_mac_ipv4_gtpc_symmetric(self):
>          self.switch_testpmd(symmetric=True)
> +        self.pmd_output.execute_cmd('vlan set filter on 0')
> +        self.pmd_output.execute_cmd('rx_vlan add 1 0')
> 
> self.rssprocess.handle_rss_distribute_cases(cases_info=mac_ipv4_gtpc_symmet
> ric_toeplitz)
> 
>      def test_mac_ipv6_gtpc_symmetric(self):
>          self.switch_testpmd(symmetric=True)
> +        self.pmd_output.execute_cmd('vlan set filter on 0')
> +        self.pmd_output.execute_cmd('rx_vlan add 1 0')
> +
> 
> self.rssprocess.handle_rss_distribute_cases(cases_info=mac_ipv6_gtpc_symmet
> ric_toeplitz)
> 
>      def tear_down(self):
> --
> 2.17.1