[dts] [PATCH V1] tests/userspace_ethtool:rename ETH to RTE_ETH

[Jiang, YuX]

> -----Original Message-----
> From: Tu, Lijuan <lijuan.tu at intel.com>
> Sent: Monday, November 22, 2021 11:27 PM
> To: Yang, LeweiX <leweix.yang at intel.com>; dts at dpdk.org
> Cc: Yang, LeweiX <leweix.yang at intel.com>
> Subject: RE: [dts] [PATCH V1] tests/userspace_ethtool:rename ETH to
> RTE_ETH
> 
> 
> 
> > -----Original Message-----
> > From: dts <dts-bounces at dpdk.org> On Behalf Of Lewei Yang
> > Sent: 2021年11月1日 23:24
> > To: dts at dpdk.org
> > Cc: Yang, LeweiX <leweix.yang at intel.com>
> > Subject: [dts] [PATCH V1] tests/userspace_ethtool:rename ETH to
> > RTE_ETH
> >
> > From: YangLewei <leweix.yang at intel.com>
> >
> > According to dpdk commit 295968d17407("ethdev: add namespace"),
> rename
> > ETH to RTE_ETH
> >
> > Signed-off-by: YangLewei <leweix.yang at intel.com>
> > ---
> >  test_plans/userspace_ethtool_test_plan.rst | 2 +-
> >  tests/TestSuite_userspace_ethtool.py       | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/test_plans/userspace_ethtool_test_plan.rst
> > b/test_plans/userspace_ethtool_test_plan.rst
> > index ca86beaf..9dca4b49 100644
> > --- a/test_plans/userspace_ethtool_test_plan.rst
> > +++ b/test_plans/userspace_ethtool_test_plan.rst
> > @@ -164,7 +164,7 @@ Test Case: Vlan test
> >
> >  enable vlan filter flag in main.c of dpdk's ethtool::
> >
> > -    sed -i -e '/cfg_port.txmode.mq_mode =
> >
> ETH_MQ_TX_NONE;$/a\\cfg_port.rxmode.offloads|=DEV_RX_OFFLOAD_VL
> AN
> > _FILTER;' examples/ethtool/ethtool-app/main.c
> > +    sed -i -e '/cfg_port.txmode.mq_mode =
> > +
> >
> RTE_ETH_MQ_TX_NONE;$/a\\cfg_port.rxmode.offloads|=DEV_RX_OFFLOA
> D_
> > VLAN_
> > + FILTER;' examples/ethtool/ethtool-app/main.c
> >
> >  re-compile examples/ethtool::
> >
> > diff --git a/tests/TestSuite_userspace_ethtool.py
> > b/tests/TestSuite_userspace_ethtool.py
> > index 4536b7d1..8fae4f2c 100644
> > --- a/tests/TestSuite_userspace_ethtool.py
> > +++ b/tests/TestSuite_userspace_ethtool.py
> > @@ -449,7 +449,7 @@ class TestUserspaceEthtool(TestCase):
> >          """
> >          main_file = "examples/ethtool/ethtool-app/main.c"
> >          # enable vlan filter
> > -        self.dut.send_expect("sed -i -e '/cfg_port.txmode.mq_mode =
> >
> ETH_MQ_TX_NONE;$/a\\cfg_port.rxmode.offloads|=DEV_RX_OFFLOAD_VL
> AN
> > _FILTER;' %s" % main_file, "# ")
> > +        self.dut.send_expect("sed -i -e '/cfg_port.txmode.mq_mode =
> > +
> >
> RTE_ETH_MQ_TX_NONE;$/a\\cfg_port.rxmode.offloads|=DEV_RX_OFFLOA
> D_
> > VLAN_
> > + FILTER;' %s" % main_file, "# ")
> 
> Can we test the point and don't modify DPDK.
> 
If we do not modify DPDK code, it tests failed. More details see the attached.
Port 0: VLAN-filtering disabled
Port 0: VLAN filtering disabled
Test Case test_ethtool_vlan Result FAILED: 'Failed to filter Rx vlan packet'

> >
> >          # build sample app
> >          self.build_ethtool()
> > --
> > 2.33.1

-------------- next part --------------
A non-text attachment was scrubbed...
Name: TestUserspaceEthtool.log
Type: application/octet-stream
Size: 62019 bytes
Desc: TestUserspaceEthtool.log
URL: <http://mails.dpdk.org/archives/dts/attachments/20211123/ba058481/attachment.obj>