[dts][PATCH V1 0/2] tests/tso: modify get_chksum_value_and_verify to fix a checksum-verify error and improve the performance
Ke Xu
ke1.xu at intel.com
Tue Aug 23 07:59:37 CEST 2022
Function get_chksum_value_and_verify in test suite TSO case test_tso_tunneling
cannot verify checksum error. Duplicated call to packet.read_pcapfile will
change the packet sequence stored in packet.pktgen.pkts, leading to a wrongly
organized packet sequence writen to file, and fails the following checksum
verifying.
The wrongly used methods also lead to a low effeciency. Duplicated call to
packet.read_pcapfile will lengthen the packet sequence stored in
packet.pktgen.pkts. Duplicated call to packet.save_pcapfile is also time
consuming.
There is also a misuse of show method that *.show() will print a packet info,
but will not return a string. The *.show will return a method object, and the
following str(out) will turn the method object into a string, so here when use
out = x.show, checksum looking up in str(out) it is equivalent to that in
repr(x).
In the first commit, the checksum verifying problem is fixed.
In the second commit, this function is improved that the case running time is
decresed by 2 minutes.
Ke Xu (2):
tests/tso: modify get_chksum_value_and_verify to fix a checksum-verify
error
tests/tso: modify get_chksum_value_and_verify to improve the
performance
tests/TestSuite_tso.py | 26 +++++++++++++++-----------
1 file changed, 15 insertions(+), 11 deletions(-)
--
2.25.1
More information about the dts
mailing list