[dts] [PATCH V1 3/4] framework/*: removed makefile from framework

[Owen Hilyard]

>
> -        build_type = load_global_setting(HOST_BUILD_TYPE_SETTING)
> -        set_build_options = getattr(self, 'set_build_options_%s' %
> (build_type))
> +        set_build_options = getattr(self, 'set_build_options_meson')
>          set_build_options(config_parms, config_file)
>

It seems like this could just be:

set_build_options_meson(config_parms, config_file)

That avoids using reflection to get the function and is much easer to read
in my opinion

 build_install_dpdk = getattr(self, 'build_install_dpdk_%s_meson' %
> self.get_os_type())


While changes are being made here, could you convert this to use a chain of
if statements?

 build_dpdk_apps = getattr(self, 'build_dpdk_apps_%s_meson' %
> self.get_os_type())


Same as the last one.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mails.dpdk.org/archives/dts/attachments/20220112/0e1cc54f/attachment.htm>