[dts] [V4] framework/*: Modified create_eal_parameters API to support flexibility

Dong, JunX junx.dong at intel.com
Tue Mar 15 02:38:34 CET 2022


Ok, I will confirm and fix it, thanks Juraj.

> -----Original Message-----
> From: Juraj Linkeš <juraj.linkes at pantheon.tech>
> Sent: Monday, March 14, 2022 6:10 PM
> To: Dong, JunX <junx.dong at intel.com>; dts at dpdk.org
> Cc: Tu, Lijuan <lijuan.tu at intel.com>; Sun, QingX <qingx.sun at intel.com>
> Subject: RE: [dts] [V4] framework/*: Modified create_eal_parameters API to
> support flexibility
> 
> > Subject: [dts] [V4] framework/*: Modified create_eal_parameters API to
> > support flexibility
> >
> > Signed-off-by: Jun Dong <junx.dong at intel.com>
> 
> 
> >  class ParameterInvalidException(Exception):
> > -    pass
> > +    def __init__(self, param_name: str, param_value: Any):
> > +        self.param_name = param_name
> > +        self.param_value = param_value
> > +
> > +    def __str__(self) -> str:
> > +        return f'Invalid parameter of {self.param_name} about value
> > + of
> > {self.param_value}, Please reference API doc.'
> > +
> >
> 
> Hi Jun, the above section of the patch introduced these errors:
> framework/tester.py:277: [E] E1120 No value for argument 'param_value' in
> constructor call [pylint]
> framework/tester.py:286: [E] E1120 No value for argument 'param_value' in
> constructor call [pylint]
> framework/tester.py:298: [E] E1120 No value for argument 'param_value' in
> constructor call [pylint]
> 
> Would you please fix the usage of the newly implemented exception?
> 
> Thanks,
> Juraj



More information about the dts mailing list