[dts][PATCH V1 2/2] tests/tso: modify get_chksum_value_and_verify to improve the performance
lijuan.tu at intel.com
lijuan.tu at intel.com
Fri Sep 2 03:57:50 CEST 2022
On Tue, 23 Aug 2022 05:59:39 +0000, Ke Xu <ke1.xu at intel.com> wrote:
> Function "get_chksum_value_and_verify" in test suite TSO case test_tso_tunneling
> is of low efficiency. Methods are wrongly used.
>
> Duplicated call to method "packet.read_pcapfile" in this function will lengthen
> the packet sequence stored in "packet.pktgen.pkts", consuming more time when
> save pcap file. Duplicated call to method "packet.save_pcapfile" is also time
> consuming.
>
> Method "pks.show" and "self.pks1[i].show" is not used as expected. "*.show" is
> used to print the packet object, not intended to return a string. Current code
> is actually getting a method object and using "str(*)" method to turn a method
> object to a string, this may fail when "*.show" method is updated. The packet
> information printing here is equivilant to "repr(pks)".
>
> Signed-off-by: Ke Xu <ke1.xu at intel.com>
Acked-by: Lijuan Tu <lijuan.tu at intel.com>
Series applied, thanks
More information about the dts
mailing list