[spp] [PATCH 25/57] spp_vf: add new log and line break

x-fn-spp at sl.ntt-tx.co.jp x-fn-spp at sl.ntt-tx.co.jp
Thu Dec 28 05:55:32 CET 2017


From: Hiroyuki Nakamura <nakamura.hioryuki at po.ntt-tx.co.jp>

* Add new log of command response for better understanding.

Signed-off-by: Daiki Yamashita <yamashita.daiki.z01 at as.ntt-tx.co.jp>
Signed-off-by: Yasufum Ogawa <ogawa.yasufumi at lab.ntt.co.jp>
---
 src/vf/command_conn.c |  2 +-
 src/vf/command_proc.c | 10 ++++++++--
 2 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/src/vf/command_conn.c b/src/vf/command_conn.c
index edd4d4c..7da4eec 100644
--- a/src/vf/command_conn.c
+++ b/src/vf/command_conn.c
@@ -89,7 +89,6 @@ spp_receive_message(int *sock, char **strbuf)
 	size_t rx_buf_sz = MESSAGE_BUFFER_BLOCK_SIZE;
 
 	ret = recv(*sock, rx_buf, rx_buf_sz, 0);
-	RTE_LOG(DEBUG, SPP_COMMAND_PROC, "Receive message. count=%d\n", ret);
 	if (ret <= 0) {
 		if (ret == 0) {
 			RTE_LOG(INFO, SPP_COMMAND_PROC,
@@ -108,6 +107,7 @@ spp_receive_message(int *sock, char **strbuf)
 		return -1;
 	}
 
+	RTE_LOG(DEBUG, SPP_COMMAND_PROC, "Receive message. count=%d\n", ret);
 	n_rx = ret;
 
 	new_strbuf = spp_strbuf_append(*strbuf, rx_buf, n_rx);
diff --git a/src/vf/command_proc.c b/src/vf/command_proc.c
index 097483c..cda72be 100644
--- a/src/vf/command_proc.c
+++ b/src/vf/command_proc.c
@@ -256,6 +256,9 @@ send_decode_error_response(int *sock, const struct spp_command_request *request,
 	msg = json_dumps(top_obj, JSON_INDENT(2));
 	json_decref(top_obj);
 
+	RTE_LOG(INFO, SPP_COMMAND_PROC, "Make command response (decode error). "
+			"response_str=\n%s\n", msg);
+
 	/* send response to requester */
 	ret = spp_send_message(sock, msg, strlen(msg));
 	if (unlikely(ret != 0)) {
@@ -303,10 +306,13 @@ send_command_result_response(int *sock, const struct spp_command_request *reques
 	msg = json_dumps(top_obj, JSON_INDENT(2));
 	json_decref(top_obj);
 
+	RTE_LOG(INFO, SPP_COMMAND_PROC, "Make command response (command result). "
+			"response_str=\n%s\n", msg);
+
 	/* send response to requester */
 	ret = spp_send_message(sock, msg, strlen(msg));
 	if (unlikely(ret != 0)) {
-		RTE_LOG(ERR, SPP_COMMAND_PROC, "Failed to send decode error response.");
+		RTE_LOG(ERR, SPP_COMMAND_PROC, "Failed to send command result response.");
 		/* not return */
 	}
 
@@ -329,7 +335,7 @@ process_request(int *sock, const char *request_str, size_t request_str_len)
 	memset(command_results, 0, sizeof(command_results));
 
 	RTE_LOG(INFO, SPP_COMMAND_PROC, "Start command request processing. "
-			"request_str=%.*s\n", (int)request_str_len, request_str);
+			"request_str=\n%.*s\n", (int)request_str_len, request_str);
 
 	/* decode request message */
 	ret = spp_command_decode_request(
-- 
1.9.1



More information about the spp mailing list