[spp] [PATCH 30/57] spp_vf: change order of command result in json object

x-fn-spp at sl.ntt-tx.co.jp x-fn-spp at sl.ntt-tx.co.jp
Thu Dec 28 05:55:37 CET 2017


From: Hiroyuki Nakamura <nakamura.hioryuki at po.ntt-tx.co.jp>

* Change order of command result in json object (bug fix).

Signed-off-by: Daiki Yamashita <yamashita.daiki.z01 at as.ntt-tx.co.jp>
Signed-off-by: Yasufum Ogawa <ogawa.yasufumi at lab.ntt.co.jp>
---
 src/vf/command_proc.c | 22 +++++++++++++++-------
 1 file changed, 15 insertions(+), 7 deletions(-)

diff --git a/src/vf/command_proc.c b/src/vf/command_proc.c
index 81bb625..291e3da 100644
--- a/src/vf/command_proc.c
+++ b/src/vf/command_proc.c
@@ -244,6 +244,10 @@ send_decode_error_response(int *sock, const struct spp_command_request *request,
 		return;
 	}
 
+	/* **
+	 * output order of object in string is inverse to addition order
+	 * **/
+
 	/* create & append result array */
 	ret = append_response_decode_results_object(top_obj, request, decode_error);
 	if (unlikely(ret != 0)) {
@@ -284,13 +288,9 @@ send_command_result_response(int *sock, const struct spp_command_request *reques
 		return;
 	}
 
-	/* create & append result array */
-	ret = append_response_command_results_object(top_obj, request, command_results);
-	if (unlikely(ret != 0)) {
-		RTE_LOG(ERR, SPP_COMMAND_PROC, "Failed to make command result response.");
-		json_decref(top_obj);
-		return;
-	}
+	/* **
+	 * output order of object in string is inverse to addition order
+	 * **/
 
 	/* append process information value */
 	if (request->is_requested_process) {
@@ -302,6 +302,14 @@ send_command_result_response(int *sock, const struct spp_command_request *reques
 		}
 	}
 
+	/* create & append result array */
+	ret = append_response_command_results_object(top_obj, request, command_results);
+	if (unlikely(ret != 0)) {
+		RTE_LOG(ERR, SPP_COMMAND_PROC, "Failed to make command result response.");
+		json_decref(top_obj);
+		return;
+	}
+
 	/* serialize */
 	msg = json_dumps(top_obj, JSON_INDENT(2));
 	json_decref(top_obj);
-- 
1.9.1



More information about the spp mailing list