[spp] [PATCH 02/57] spp_vf: support multi process

Ferruh Yigit ferruh.yigit at intel.com
Wed Feb 7 17:50:56 CET 2018


On 12/28/2017 4:55 AM, x-fn-spp at sl.ntt-tx.co.jp wrote:
> From: Hiroyuki Nakamura <nakamura.hioryuki at po.ntt-tx.co.jp>
> 
> spp_vf was only a single process so far, but spp_vf supported
> multi process. Following modification has been made.
> 
> * Change naming machanism to allow hashtable on shared memory
>   to be operated by multiple processes.
> * Get config file path from command line argument.
> 
> And following modification has been made.
> * Modify comment.
> * Add and modify log message.
> * Add function to remove vhost socket file.
> 
> Signed-off-by: Daiki Yamashita <yamashita.daiki.z01 at as.ntt-tx.co.jp>
> Signed-off-by: Yasufum Ogawa <ogawa.yasufumi at lab.ntt.co.jp>

<...>

> @@ -669,6 +732,24 @@ print_ring_latency_stats()
>  #endif /* SPP_RINGLATENCYSTATS_ENABLE */
>  
>  /*
> + * VHOST用ソケットファイル削除
> + */
> +static void
> +del_vhost_sockfile(struct patch_info *vhost_patchs)
> +{
> +	int cnt;
> +	for (cnt = 0; cnt < RTE_MAX_ETHPORTS; cnt++) {
> +		if (likely(vhost_patchs[cnt].use_flg == 0)) {
> +			/* VHOST未使用はスキップ */
> +			continue;
> +		}
> +
> +		/* 使用していたVHOSTについて削除を行う */

Would you mind translating comments to English. It helps if code understood by
more people.

<...>

>  		}
> +
> +		/* Skip dpdk parameters */
> +		argc -= ret_dpdk;
> +		argv += ret_dpdk;
> +
> +		/* Set log level  */
> +		rte_log_set_global_level(RTE_LOG_LEVEL);

Hi Daiki, Yasufum,

This breaks the build with dpdk master because RTE_LOG_LEVEL removed in this
release.

Can you please check this?


More information about the spp mailing list