[spp] [PATCH 2/2] spp_vf: update to improve usability
Ferruh Yigit
ferruh.yigit at intel.com
Thu Feb 22 12:50:12 CET 2018
On 2/8/2018 3:18 PM, ogawa.yasufumi at lab.ntt.co.jp (ogawa.yasufumi at lab.ntt.co.jp)
wrote:
> From: Yasufumi Ogawa <ogawa.yasufumi at lab.ntt.co.jp>
>
> This update is same as previous patch for spp.py.
>
> * Override emptyline() of Shell class to not repeat previous command.
>
> * Override default() to accept comment line. To find the comment, add
> is_comment_line() which support python and C style comment.
>
> * Remove lower() for user's input to avoid unexpected behaviour.
>
> Signed-off-by: Yasufumi Ogawa <ogawa.yasufumi at lab.ntt.co.jp>
Hi Yasufumi,
This is already applied but I am concerned about having two version of python
script, spp.py and spp_vf.py.
Is there a long term plan for them?
Why we are maintaining two copies and they are slightly differentiated now, as
some features only supported in spp_vf.py?
Does it make sense to merge them?
Thanks,
ferruh
More information about the spp
mailing list