[spp] [PATCH 00/13] Change structure of SPP controller

ogawa.yasufumi at lab.ntt.co.jp ogawa.yasufumi at lab.ntt.co.jp
Tue Mar 6 11:50:42 CET 2018


From: Yasufumi Ogawa <ogawa.yasufumi at lab.ntt.co.jp>

SPP controller 'spp.py' is monolithic and has got to be large. It is
hard to be maintained because several classes are included in the file
and global variables are shared among its instances.

This seriese of update is to move classes and methods in spp.py to
'controller/' as separated files for maintainability. It also includes
additional commands.

Yasufumi Ogawa (13):
  spp: move controller to sub directory
  controller: move connection threads
  controller: aggregate logger to spp_common.py
  controller: add load command
  controller: move common methods to shell_lib
  controller: add filter for py to compl_common
  controller: refactor shell.py
  controller: change logger output to logfile
  controller: add do_topo to shell.py
  controller: add topo.py
  controller: add topo_subgraph command
  controller: add cat and less command
  controller: create log directory

 .gitignore                           |   5 +-
 src/controller/__init__.py           |   0
 src/controller/command/__init__.py   |   0
 src/controller/command/hello.py      |  28 +
 src/controller/conn_thread.py        | 246 +++++++++
 src/controller/shell.py              | 724 ++++++++++++++++++++++++++
 src/controller/shell_lib/__init__.py |   0
 src/controller/shell_lib/common.py   |  98 ++++
 src/controller/spp.py                | 111 ++++
 src/controller/spp_common.py         |  58 +++
 src/controller/topo.py               | 341 ++++++++++++
 src/spp.py                           | 984 +----------------------------------
 12 files changed, 1614 insertions(+), 981 deletions(-)
 create mode 100644 src/controller/__init__.py
 create mode 100644 src/controller/command/__init__.py
 create mode 100644 src/controller/command/hello.py
 create mode 100644 src/controller/conn_thread.py
 create mode 100644 src/controller/shell.py
 create mode 100644 src/controller/shell_lib/__init__.py
 create mode 100644 src/controller/shell_lib/common.py
 create mode 100644 src/controller/spp.py
 create mode 100644 src/controller/spp_common.py
 create mode 100644 src/controller/topo.py

-- 
2.13.1



More information about the spp mailing list