[dpdk-stable] [dpdk-dev] [PATCH] net/qede: fix resource leak

[Ferruh Yigit]

On 11/30/2016 12:32 PM, Yong Wang wrote:
> Current code does not close 'fd' on function exit, leaking resources.
> 
> Signed-off-by: Yong Wang <wang.yong19 at zte.com.cn>

CC: stable at dpdk.org

> ---
>  drivers/net/qede/qede_main.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/net/qede/qede_main.c b/drivers/net/qede/qede_main.c
> index ab22409..b666e1c 100644
> --- a/drivers/net/qede/qede_main.c
> +++ b/drivers/net/qede/qede_main.c
> @@ -137,6 +137,7 @@ static int qed_load_firmware_data(struct ecore_dev *edev)
>  
>  	if (fstat(fd, &st) < 0) {
>  		DP_NOTICE(edev, false, "Can't stat firmware file\n");
> +		close(fd);
>  		return -1;
>  	}
>  
> @@ -158,9 +159,11 @@ static int qed_load_firmware_data(struct ecore_dev *edev)
>  	if (edev->fw_len < 104) {
>  		DP_NOTICE(edev, false, "Invalid fw size: %" PRIu64 "\n",
>  			  edev->fw_len);
> +		close(fd);
>  		return -EINVAL;
>  	}
>  
> +	close(fd);
>  	return 0;
>  }
>  #endif
>