[dpdk-stable] patch 'net/cxgbe/base: initialize variable before reading EEPROM' has been queued to stable release 16.11.1
Yuanhan Liu
yuanhan.liu at linux.intel.com
Wed Feb 15 07:26:24 CET 2017
Hi,
FYI, your patch has been queued to stable release 16.11.1
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable
yet. It will be pushed if I get no objections before 02/18/17.
So please shout if anyone has objections.
Thanks.
--yliu
---
>From fe835334ae7fef278b1574fa50e1b458754404bb Mon Sep 17 00:00:00 2001
From: Emmanuel Roullit <emmanuel.roullit at gmail.com>
Date: Tue, 24 Jan 2017 21:48:57 +0100
Subject: [PATCH] net/cxgbe/base: initialize variable before reading EEPROM
[ upstream commit dd995b23dfc22a28edc565ce6163a5c98068d302 ]
data value could have been garbage if VPD access timed out for VPD read
request could not been issued.
Found with clang static analysis:
drivers/net/cxgbe/base/t4_hw.c:1577:22:
warning: The left operand of '&' is a garbage value
} while ((stats_reg & 0x1) && --max_poll);
~~~~~~~~~ ^
Fixes: fe0bd9ee5da3 ("net/cxgbe: support EEPROM access")
Signed-off-by: Emmanuel Roullit <emmanuel.roullit at gmail.com>
---
drivers/net/cxgbe/base/t4_hw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/cxgbe/base/t4_hw.c b/drivers/net/cxgbe/base/t4_hw.c
index 7e79adf..c089b06 100644
--- a/drivers/net/cxgbe/base/t4_hw.c
+++ b/drivers/net/cxgbe/base/t4_hw.c
@@ -1532,7 +1532,7 @@ int t4_seeprom_write(struct adapter *adapter, u32 addr, u32 data)
{
unsigned int base = adapter->params.pci.vpd_cap_addr;
int ret;
- u32 stats_reg;
+ u32 stats_reg = 0;
int max_poll;
/* VPD Accesses must alway be 4-byte aligned!
--
1.9.0
More information about the stable
mailing list