[dpdk-stable] patch 'usertools: fix active interface detection when binding' has been queued to stable release 16.11.1

Yuanhan Liu yuanhan.liu at linux.intel.com
Wed Feb 15 07:26:50 CET 2017


Hi,

FYI, your patch has been queued to stable release 16.11.1

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable
yet. It will be pushed if I get no objections before 02/18/17.
So please shout if anyone has objections.

Thanks.

	--yliu

---
>From 2aca8654b0a35536078c5cb34bd3e2ceea2d3748 Mon Sep 17 00:00:00 2001
From: Yoni Gilad <yonig at radcom.com>
Date: Tue, 10 Jan 2017 17:14:21 +0000
Subject: [PATCH] usertools: fix active interface detection when binding

[ backported from upstream commit 617d90527f8a72e9a1a258f2e6885b46ffb6fa46 ]

When adding crypto devices, the "Active" and "Ssh_if" attributes of
existing network devices were reset. This causes the following issues:

- Network interfaces aren't marked as "*Active*" in the --status output.
- Active network interfaces can be unbound without the --force option,
  causing loss of network connection.

The reset was caused by the call to devices[d].update in
get_crypto_details.

This patch prevents the update on non-crypto devices.

Fixes: cb4a1d14bf3e ("tools: bind crypto devices")

Signed-off-by: Yoni Gilad <yonig at radcom.com>
Acked-by: Pablo de Lara <pablo.de.lara.guarch at intel.com>
---
 tools/dpdk-devbind.py | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tools/dpdk-devbind.py b/tools/dpdk-devbind.py
index f1d374d..fef59c4 100755
--- a/tools/dpdk-devbind.py
+++ b/tools/dpdk-devbind.py
@@ -328,6 +328,9 @@ def get_crypto_details():
 
     # based on the basic info, get extended text details
     for d in devices.keys():
+        if devices[d]["Class"][0:2] != CRYPTO_BASE_CLASS:
+            continue
+
         # get additional info and add it to existing data
         devices[d] = devices[d].copy()
         devices[d].update(get_pci_device_details(d).items())
-- 
1.9.0



More information about the stable mailing list