[dpdk-stable] patch 'net/qede: fix possible null pointer dereference' has been queued to stable release 17.08.1

Yuanhan Liu yliu at fridaylinux.org
Tue Nov 21 14:15:59 CET 2017


Hi,

FYI, your patch has been queued to stable release 17.08.1

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/24/17. So please
shout if anyone has objections.

Thanks.

	--yliu

---
>From f869c214e03d7ba2d3216179e6220efb86316c80 Mon Sep 17 00:00:00 2001
From: RongQiang Xie <xie.rongqiang at zte.com.cn>
Date: Thu, 24 Aug 2017 15:12:33 +0800
Subject: [PATCH] net/qede: fix possible null pointer dereference

[ upstream commit ef86e67ad5d873573882e19d92a206a842d22927 ]

In function qede_rss_reta_update(), the pointer params returned from
call to function rte_zmalloc() may be NULL and will be dereferenced.
So, should judge if the params is NULL or not.

Fixes: 8b3ee85efe11 ("net/qede: fix RSS table entries for 100G adapter")

Signed-off-by: RongQiang Xie <xie.rongqiang at zte.com.cn>
Acked-by: Harish Patil <harish.patil at cavium.com>
---
 drivers/net/qede/qede_ethdev.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c
index 0e05989..4e9e89f 100644
--- a/drivers/net/qede/qede_ethdev.c
+++ b/drivers/net/qede/qede_ethdev.c
@@ -2012,6 +2012,10 @@ int qede_rss_reta_update(struct rte_eth_dev *eth_dev,
 	memset(&vport_update_params, 0, sizeof(vport_update_params));
 	params = rte_zmalloc("qede_rss", sizeof(*params) * edev->num_hwfns,
 			     RTE_CACHE_LINE_SIZE);
+	if (params == NULL) {
+		DP_ERR(edev, "failed to allocate memory\n");
+		return -ENOMEM;
+	}
 
 	for (i = 0; i < reta_size; i++) {
 		idx = i / RTE_RETA_GROUP_SIZE;
-- 
2.7.4



More information about the stable mailing list