[dpdk-stable] patch 'fix ethdev port id validation' has been queued to stable release 18.02.2
Thomas Monjalon
thomas at monjalon.net
Mon Apr 30 17:04:49 CEST 2018
30/04/2018 16:41, luca.boccassi at gmail.com:
> Hi,
>
> FYI, your patch has been queued to stable release 18.02.2
>
> Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
> It will be pushed if I get no objections before 05/02/18. So please
> shout if anyone has objections.
I did not plan to backport it. But yes, it may be a good idead.
In this case, you need to backport some fixes on top of it:
app/testpmd: fix build without i40e
examples/flow_classify: fix validation in port init
> ---
> From 17bf70baba04313dc1ceef180f2f19da7f5ecad1 Mon Sep 17 00:00:00 2001
> From: Thomas Monjalon <thomas at monjalon.net>
> Date: Thu, 5 Apr 2018 17:33:21 +0200
> Subject: [PATCH] fix ethdev port id validation
>
> [ upstream commit a9dbe180222680edf8c49e86791f972549ce5be3 ]
>
> Some DPDK applications wrongly assume these requirements:
> - no hotplug, i.e. ports are never detached
> - all allocated ports are available to the application
>
> Such application assume a valid port index is in the range [0..count[.
>
> There are three consequences when using such wrong design:
> - new ports having an index higher than the port count won't be valid
> - old ports being detached (RTE_ETH_DEV_UNUSED) can be valid
>
> Such mistake will be less common with growing hotplug awareness.
> All applications and examples inside this repository - except testpmd -
> must be fixed to use the function rte_eth_dev_is_valid_port.
>
> Signed-off-by: Thomas Monjalon <thomas at monjalon.net>
More information about the stable
mailing list